[PATCH] Re: fix_hostname() in 1.3.30-dev broken

2004-03-24 Thread Jim Jagielski
Whatever uses ap_get_server_port() would use the Port number included in the Host: header. This includes mod_vhost_alias, mod_proxy, mod_rewrite and Apache itself when it creates self- referential URLs (hence UseCanonicalName). Note that it's ONLY when UseCanonicalName is Off that this is an

Re: fix_hostname() in 1.3.30-dev broken

2004-03-22 Thread Jim Jagielski
Roy T. Fielding wrote: Ugg... fix_hostname() in 1.3.30-dev (and previous) are broken such that it does *not* update parsed_uri with the port and port_str value from the Host header. This means that with a request like: % telnet localhost GET / HTTP/1.1 Host:

fix_hostname() in 1.3.30-dev broken

2004-03-18 Thread Jim Jagielski
Ugg... fix_hostname() in 1.3.30-dev (and previous) are broken such that it does *not* update parsed_uri with the port and port_str value from the Host header. This means that with a request like: % telnet localhost GET / HTTP/1.1 Host: foo: that the '' port value from the

Re: fix_hostname() in 1.3.30-dev broken

2004-03-18 Thread Roy T. Fielding
Ugg... fix_hostname() in 1.3.30-dev (and previous) are broken such that it does *not* update parsed_uri with the port and port_str value from the Host header. This means that with a request like: % telnet localhost GET / HTTP/1.1 Host: foo: that the '' port value from the