Re: http://svn.apache.org/viewvc?view=revrevision=602469

2007-12-08 Thread Ruediger Pluem
On 12/08/2007 04:07 PM, Jim Jagielski wrote: I didn't see this patch in the commit list but did see it referred to in the 2.2 STATUS file... I'm reviewing the patch now but two things did stick out: -apr_brigade_cleanup(ctx-ctxbb); -APR_BUCKET_REMOVE(b); -

http://svn.apache.org/viewvc?view=revrevision=602469

2007-12-08 Thread Jim Jagielski
I didn't see this patch in the commit list but did see it referred to in the 2.2 STATUS file... I'm reviewing the patch now but two things did stick out: -apr_brigade_cleanup(ctx-ctxbb); -APR_BUCKET_REMOVE(b); -APR_BRIGADE_INSERT_TAIL(passbb, b); -

Re: http://svn.apache.org/viewvc?view=revrevision=602469

2007-12-08 Thread Jim Jagielski
On Dec 8, 2007, at 11:39 AM, Ruediger Pluem wrote: The reason why the current code handles FLUSH separately is though, yes, the ap_pass_brigade is done at the end of the while loop, that is *only* done when we're done handling the full brigade... The intent was to honor flushes in the brigade

Re: http://svn.apache.org/viewvc?view=revrevision=602469

2007-12-08 Thread Jim Jagielski
On Dec 8, 2007, at 11:39 AM, Ruediger Pluem wrote: In fact the patch does all this as it passes the passbb brigade down the chain after *each* processed bucket of the original brigade (the ap_pass_brigade is at *the end* of the while loop *not* after the while loop). I didn't catch that when