Re: huge memory leak in 2.0.x

2004-06-16 Thread Joe Orton
On Wed, Jun 16, 2004 at 10:02:21AM -0400, Marc Heckmann wrote: On Wed, Jun 16, 2004 at 02:46:58PM +0100, Joe Orton wrote: Thanks for testing this out Marc: unfortunately these patches break assumptions that various filters are making; applying them alone is likely to cause lots of random

Re: huge memory leak in 2.0.x

2004-06-15 Thread Joe Orton
http://issues.apache.org/bugzilla/show_bug.cgi?id=23567 On Mon, Jun 14, 2004 at 01:45:26PM -0600, Brad Nicholes wrote: Actually I think this was addressed quite a while ago with the introduction of the MaxMemFree directive. This problem sounds a lot like the bucket issue where memory

Re: huge memory leak in 2.0.x

2004-06-15 Thread Joe Orton
On Tue, Jun 15, 2004 at 03:23:42PM +0100, Joe Orton wrote: http://issues.apache.org/bugzilla/show_bug.cgi?id=23567 OK, the issues I was having with using the bucket allocator to allocate the brigade were just my own screwups. So, the patches needed to fix this issue are attached: 1) re-use pool

Re: huge memory leak in 2.0.x

2004-06-15 Thread Cliff Woolley
On Tue, 15 Jun 2004, Joe Orton wrote: 2) allocate brigade structures using the bucket allocator If you're going to do this, then surely you need to call apr_pool_cleanup_register() somewhere? === RCS file:

Re: huge memory leak in 2.0.x

2004-06-15 Thread Joe Orton
On Tue, Jun 15, 2004 at 03:14:53PM -0400, Cliff Woolley wrote: On Tue, 15 Jun 2004, Joe Orton wrote: 2) allocate brigade structures using the bucket allocator If you're going to do this, then surely you need to call apr_pool_cleanup_register() somewhere? apr_brigade_create() does that

Re: huge memory leak in 2.0.x

2004-06-15 Thread Cliff Woolley
On Tue, 15 Jun 2004, Joe Orton wrote: apr_brigade_create() does that already. Oh, duh, of course it does. As many times as I've looked at that line, you'd think I'd have it memorized by now. :)

Re: huge memory leak in 2.0.x

2004-06-15 Thread Bill Stoddard
@@ -1340,7 +1343,7 @@ /* Run cleanups */ run_cleanups(pool-cleanups); -pool-cleanups = NULL; +pool-free_cleanups = pool-cleanups = NULL; /* If new child pools showed up, this is a reason to raise a flag */ if (pool-child) @@ -1886,7 +1889,13 @@ #endif /*

Re: huge memory leak in 2.0.x

2004-06-15 Thread Bill Stoddard
Bill Stoddard wrote: @@ -1340,7 +1343,7 @@ /* Run cleanups */ run_cleanups(pool-cleanups); -pool-cleanups = NULL; +pool-free_cleanups = pool-cleanups = NULL; /* If new child pools showed up, this is a reason to raise a flag */ if (pool-child) @@ -1886,7 +1889,13 @@

huge memory leak in 2.0.x

2004-06-14 Thread Marc Heckmann
Hi, [I'm writing to the dev list because it seems that not enough apache developers have noticed or taken interest into the original PR's on this bug] This is a real and easy to reproduce bug that has been agonizing me for a quite a while. It's been reported since at least October '03. 1.3.x

Re: huge memory leak in 2.0.x

2004-06-14 Thread Brad Nicholes
Actually I think this was addressed quite a while ago with the introduction of the MaxMemFree directive. This problem sounds a lot like the bucket issue where memory allocated for the bucket brigade that pushes the data through from the CGI app to the wire, simply held on to the memory

Re: huge memory leak in 2.0.x

2004-06-14 Thread Marc Heckmann
So I tried setting MaxMemFree 5000, but it hasn't changed anything, I was quickly able to bloat the child httpd by an extra 17+ Mb. and it hasn't gone down since (I'm using the prefork MPM on Linux). -m On Mon, Jun 14, 2004 at 01:45:26PM -0600, Brad Nicholes wrote: Actually I think this was