Re: mod_include patch

2004-10-21 Thread Torsten Frtsch
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wednesday 20 October 2004 18:49, André Malo wrote: I want to use SSI with CGI scripts. Thus, I have configured the INCLUDES filter for my cgi-bin. But my CGI scripts generate not only text/html documents. Hence my problem, I want to say

Re: mod_include patch

2004-10-21 Thread Andr Malo
* Torsten Förtsch [EMAIL PROTECTED] wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wednesday 20 October 2004 18:49, André Malo wrote: I want to use SSI with CGI scripts. Thus, I have configured the INCLUDES filter for my cgi-bin. But my CGI scripts generate not only text/html

Re: mod_include patch

2004-10-21 Thread Nick Kew
On Thu, 21 Oct 2004, Torsten [iso-8859-15] Förtsch wrote: Why don't you just use addoutputfilterbytype? because I am using another mod_perl output filter that should be called *after* INCLUDES. There is a PerlSetOutputFilter directive that preserves filter ordering but it adds the filter

mod_include patch

2004-10-20 Thread Torsten Förtsch
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi. I want to use SSI with CGI scripts. Thus, I have configured the INCLUDES filter for my cgi-bin. But my CGI scripts generate not only text/html documents. Hence my problem, I want to say mod_include to handle only documents with content-type

Re: [PATCH] Take 3 of mod_include patch...

2001-09-06 Thread Cliff Woolley
On Thu, 6 Sep 2001, Ryan Bloom wrote: I actually hit this same seg fault in mod_jk late last night. If mod_include is changed to fix this, then we are most likely doing it wrong, and I will veto that. My point exactly. The first step is to set r-uri to NULL if it is INTERNALLY GENERATED.

Re: [PATCH] Take 3 of mod_include patch...

2001-09-06 Thread Ryan Bloom
I have some big problems with the way that location walk and directory walk work now, BTW, because if I write a module that doesn't get pages from the filesystem, I have to catch those in the map_to_storage hook, or the server will 500. Hmm... I'd have thought that was the whole point

Re: [PATCH] Take 3 of mod_include patch...

2001-09-06 Thread Cliff Woolley
On Thu, 6 Sep 2001, Ryan Bloom wrote: Hmm... I'd have thought that was the whole point of the map_to_storage hook, if its name were any indication... shrug It is, but if I am just putting together a quick module, to solve a problem and it generates the page itself, all I should have to

Re: [PATCH] Take 3 of mod_include patch...

2001-09-06 Thread Ryan Bloom
On Thursday 06 September 2001 09:36, Ian Holsman wrote: On Thu, 2001-09-06 at 08:12, Ryan Bloom wrote: I have some big problems with the way that location walk and directory walk work now, BTW, because if I write a module that doesn't get pages from the filesystem, I have to catch

Re: [PATCH] Take 3 of mod_include patch...

2001-09-06 Thread Bill Stoddard
On Thursday 06 September 2001 09:36, Ian Holsman wrote: On Thu, 2001-09-06 at 08:12, Ryan Bloom wrote: I have some big problems with the way that location walk and directory walk work now, BTW, because if I write a module that doesn't get pages from the filesystem, I have to

Re: [PATCH] Take 3 of mod_include patch...

2001-09-06 Thread Ryan Bloom
On Thursday 06 September 2001 11:54, Bill Stoddard wrote: On Thursday 06 September 2001 09:36, Ian Holsman wrote: On Thu, 2001-09-06 at 08:12, Ryan Bloom wrote: I have some big problems with the way that location walk and directory walk work now, BTW, because if I write a module

[PATCH] Take 3 of mod_include patch...

2001-09-05 Thread Justin Erenkrantz
Okay, I've cleaned this up and I think it is ready for commit. However, I'd really like some eyes on this. =-) In Ian and Brian's testing, this does seem to make mod_include faster. I can't guarantee that there aren't any bugs here, but I've tested it with what I have and looked at the code

Re: [PATCH] Take 3 of mod_include patch...

2001-09-05 Thread Brian Pane
Justin Erenkrantz wrote: [...] +/* Implements the BNDM search algorithm (as described above). + * + * n - the pattern to search for + * nl - length of the pattern to search for + * h - the string to look in + * hl - length of the string to look for + * t - precompiled bndm structure against

Re: [PATCH] Take 3 of mod_include patch...

2001-09-05 Thread Justin Erenkrantz
On Wed, Sep 05, 2001 at 06:46:45PM -0700, Brian Pane wrote: Justin Erenkrantz wrote: [...] +/* Implements the BNDM search algorithm (as described above). + * + * n - the pattern to search for + * nl - length of the pattern to search for + * h - the string to look in + * hl - length of

Re: [PATCH] Take 3 of mod_include patch...

2001-09-05 Thread Justin Erenkrantz
On Wed, Sep 05, 2001 at 07:11:37PM -0700, Justin Erenkrantz wrote: On Wed, Sep 05, 2001 at 06:46:45PM -0700, Brian Pane wrote: Justin Erenkrantz wrote: [...] +/* Implements the BNDM search algorithm (as described above). + * + * n - the pattern to search for + * nl - length of

Re: [PATCH] Take 3 of mod_include patch...

2001-09-05 Thread Justin Erenkrantz
On Wed, Sep 05, 2001 at 07:15:13PM -0700, Justin Erenkrantz wrote: Actually, I think the conditional should be: while (p = he) Thoughts? We're scanning R-L, so p points to the end of the string. It is possible to have !--# as n (which should match). -- justin No. I'm wrong. I'll shut

Re: [PATCH] Take 3 of mod_include patch...

2001-09-05 Thread Brian Pane
Justin Erenkrantz wrote: [...] Actually, I think the conditional should be: while (p = he) Thoughts? We're scanning R-L, so p points to the end of the string. It is possible to have !--# as n (which should match). -- justin I think (p he) is still the right conditional; 'he' points to the

Re: [PATCH] Take 3 of mod_include patch...

2001-09-05 Thread Justin Erenkrantz
On Wed, Sep 05, 2001 at 06:42:10PM -0700, john sachs wrote: i applied this patch and the mod_include test fails in the same spot as it has been. content file has: !--#include file=extra/inc-extra1.shtml-- 'include file' with relative path to file not in same path as the file you are

Re: [PATCH] Take 3 of mod_include patch...

2001-09-05 Thread Cliff Woolley
On Wed, 5 Sep 2001, john sachs wrote: i applied this patch and the mod_include test fails in the same spot as it has been. content file has: !--#include file=extra/inc-extra1.shtml-- 'include file' with relative path to file not in same path as the file you are requesting. Yep. This