Re: mod_md OpenSSL version requirement 1.0.0

2018-03-19 Thread Ruediger Pluem
On 03/16/2018 01:33 PM, Yann Ylavic wrote: > On Fri, Mar 16, 2018 at 1:11 PM, Eric Covener wrote: >> On Fri, Mar 16, 2018 at 7:57 AM, Stefan Eissing >> wrote: >>> Hi Rainer, >>> >>> thanks for solving this issue. The version check indeed was missing. I do >>> not think supporting ACME on serve

Re: mod_md OpenSSL version requirement 1.0.0

2018-03-16 Thread Stefan Eissing
> Am 16.03.2018 um 13:33 schrieb Yann Ylavic : > > On Fri, Mar 16, 2018 at 1:11 PM, Eric Covener wrote: >> On Fri, Mar 16, 2018 at 7:57 AM, Stefan Eissing >> wrote: >>> Hi Rainer, >>> >>> thanks for solving this issue. The version check indeed was missing. I do >>> not think supporting ACME

Re: mod_md OpenSSL version requirement 1.0.0

2018-03-16 Thread Yann Ylavic
On Fri, Mar 16, 2018 at 1:11 PM, Eric Covener wrote: > On Fri, Mar 16, 2018 at 7:57 AM, Stefan Eissing > wrote: >> Hi Rainer, >> >> thanks for solving this issue. The version check indeed was missing. I do >> not think supporting ACME on servers with such old OpenSSL is really >> something to s

Re: mod_md OpenSSL version requirement 1.0.0

2018-03-16 Thread Eric Covener
On Fri, Mar 16, 2018 at 7:57 AM, Stefan Eissing wrote: > Hi Rainer, > > thanks for solving this issue. The version check indeed was missing. I do not > think supporting ACME on servers with such old OpenSSL is really something to > strive for. I'd have settled for a check von 1.0.2 even. If your

Re: mod_md OpenSSL version requirement 1.0.0

2018-03-16 Thread Stefan Eissing
Hi Rainer, thanks for solving this issue. The version check indeed was missing. I do not think supporting ACME on servers with such old OpenSSL is really something to strive for. I'd have settled for a check von 1.0.2 even. If your changed check makes it working for 1.0.1 also, that's fine. My

Re: mod_md OpenSSL version requirement 1.0.0

2018-03-16 Thread Rainer Jung
Am 16.03.2018 um 12:21 schrieb Rainer Jung: It seems mod_md (trunk and 2.4, currently identical) needs OpenSSL 1.0.2 (for ASN1_TIME_diff), but with a small change (using the already existing LIBRESSL alternative code) it only needs 1.0.0. Since we still support 0.9.8a+ for 2.4.x and trunk, I t

mod_md OpenSSL version requirement 1.0.0

2018-03-16 Thread Rainer Jung
It seems mod_md (trunk and 2.4, currently identical) needs OpenSSL 1.0.2 (for ASN1_TIME_diff), but with a small change (using the already existing LIBRESSL alternative code) it only needs 1.0.0. Since we still support 0.9.8a+ for 2.4.x and trunk, I think we need to add a version check to modul