Re: mod_rewrite: RewriteEngine off doesn't work in a directory context

2010-11-06 Thread Graham Leggett
On 06 Nov 2010, at 5:21 PM, Ruediger Pluem wrote: Does this patch make sense? Do we always have a valid dconf in hook_uri2file? To be safe, I have added a check for dconf being NULL. Regards, Graham -- httpd-mod_rewrite-rewriteengine-fix.patch Description: Binary data

Re: mod_rewrite: RewriteEngine off doesn't work in a directory context

2010-11-06 Thread Graham Leggett
On 06 Nov 2010, at 5:21 PM, Ruediger Pluem wrote: Does this patch make sense? Do we always have a valid dconf in hook_uri2file? And if yes, why do we need the state field in the server conf any longer? It's because of the following function, called from a post config hook, at which poin

Re: mod_rewrite: RewriteEngine off doesn't work in a directory context

2010-11-06 Thread Ruediger Pluem
On 11/06/2010 01:39 AM, Graham Leggett wrote: > > Does this patch make sense? Do we always have a valid dconf in hook_uri2file? And if yes, why do we need the state field in the server conf any longer? Regards RĂ¼diger

mod_rewrite: RewriteEngine off doesn't work in a directory context

2010-11-05 Thread Graham Leggett
Hi all. In mod_rewrite, we have the RewriteEngine directive, that in theory is able to switch the engine on and off. In practise however, you can switch it on, but once on globally, you cannot switch it off again - the directive has no effect. This directive stores this flag in two places