Re: svn commit: r1384924 - in /httpd/httpd/trunk: include/httpd.h server/request.c

2014-04-24 Thread Christophe JAILLET
Hi, the comment is wrong. 'ap_sub_req_lookup_dirent' uses the fact that 'rnew-uri' has some extra space after the NUL. 'rnew-uri' is allocated via 'ap_escape_uri' which is defined as: #define ap_escape_uri(ppool,path) ap_os_escape_path(ppool,path,1) So, what matters here is the case in

Re: svn commit: r1384924 - in /httpd/httpd/trunk: include/httpd.h server/request.c

2014-04-24 Thread Graham Leggett
On 24 Apr 2014, at 8:34 AM, Christophe JAILLET christophe.jail...@wanadoo.fr wrote: the comment is wrong. 'ap_sub_req_lookup_dirent' uses the fact that 'rnew-uri' has some extra space after the NUL. 'rnew-uri' is allocated via 'ap_escape_uri' which is defined as: #define

Re: svn commit: r1384924 - in /httpd/httpd/trunk: include/httpd.h server/request.c

2014-04-22 Thread Christophe JAILLET
Hi, while looking at candidates for backport to synch 2.4.x and trunk, I came across this old comment update. The first part of the comment, against 'ap_os_escape_path', is, IMO, wrong. We are not guaranteed that, if partial is *not* set, that there will be one byte of additional space after

Re: svn commit: r1384924 - in /httpd/httpd/trunk: include/httpd.h server/request.c

2014-04-22 Thread Yann Ylavic
On Tue, Apr 22, 2014 at 9:47 AM, Christophe JAILLET christophe.jail...@wanadoo.fr wrote: The first part of the comment, against 'ap_os_escape_path', is, IMO, wrong. We are not guaranteed that, if partial is *not* set, that there will be one byte of additional space after the NUL. If partial