Re: svn commit: r1687564 - /httpd/httpd/branches/2.4.x/STATUS

2015-06-26 Thread Yann Ylavic
Simpler indeed, thanks. Addressed in r1687680 and backport proposal updated in r1687684. Will update the one of 2.2.x too. On Fri, Jun 26, 2015 at 2:01 AM, William A Rowe Jr wrote: > Just a quick observation on the patch, you know you can use a tristate to > avoid an int? > > Simply set the value

Re: svn commit: r1687564 - /httpd/httpd/branches/2.4.x/STATUS

2015-06-25 Thread William A Rowe Jr
Just a quick observation on the patch, you know you can use a tristate to avoid an int? Simply set the value to 2 in the config-create (the enum being off=0, on=1, unset=2), check for RHS 'unset' during the merge, and in the feature toggle test, explicitly check test for == of the non-default valu