Re: svn commit: r1695727 - in /httpd/httpd/trunk: docs/manual/mod/core.xml include/http_core.h server/core.c server/protocol.c

2015-09-15 Thread Stefan Eissing
> Am 15.09.2015 um 13:08 schrieb Yann Ylavic : > > On Tue, Sep 15, 2015 at 10:00 AM, Stefan Eissing > wrote: >> Uhm, did I mess something up (again)? My core.xml says: > > I'm afraid :) Ah! > Both s are equals: > >> ... >> >>Protocols >>Protocols available for a server/virtual host

Re: svn commit: r1695727 - in /httpd/httpd/trunk: docs/manual/mod/core.xml include/http_core.h server/core.c server/protocol.c

2015-09-15 Thread Yann Ylavic
On Tue, Sep 15, 2015 at 10:00 AM, Stefan Eissing wrote: > Uhm, did I mess something up (again)? My core.xml says: I'm afraid :) Both s are equals: > ... > > Protocols > Protocols available for a server/virtual host [] > > > > ProtocolsHonorOrder > Protocols available for a se

Re: svn commit: r1695727 - in /httpd/httpd/trunk: docs/manual/mod/core.xml include/http_core.h server/core.c server/protocol.c

2015-09-15 Thread Stefan Eissing
Uhm, did I mess something up (again)? My core.xml says: ... Protocols Protocols available for a server/virtual host Protocols protocol ... Protocols http/1.1 server configvirtual host Only available from Apache 2.4.17 and later. This directive specifies t

Re: svn commit: r1695727 - in /httpd/httpd/trunk: docs/manual/mod/core.xml include/http_core.h server/core.c server/protocol.c

2015-09-14 Thread Christophe JAILLET
Hi, Protocols and ProtocolsHonorOrder have the same description. Is it done on purpose or is it a cut'n paste error? CJ Le 13/08/2015 17:33, ic...@apache.org a écrit : Author: icing Date: Thu Aug 13 15:33:07 2015 New Revision: 1695727 URL: http://svn.apache.org/r1695727 Log: new directive Pro

Re: svn commit: r1695727 - in /httpd/httpd/trunk: docs/manual/mod/core.xml include/http_core.h server/core.c server/protocol.c

2015-09-03 Thread Stefan Eissing
Added in r1701005. > Am 03.09.2015 um 11:49 schrieb Yann Ylavic : > > On Wed, Sep 2, 2015 at 7:54 PM, Stefan Eissing > wrote: >> If we want to be more safe, we can change the Protocols default to just >> http/1.1. Also the default for ordering we can change, np. >> >> Other opinions? > > Than

Re: svn commit: r1695727 - in /httpd/httpd/trunk: docs/manual/mod/core.xml include/http_core.h server/core.c server/protocol.c

2015-09-03 Thread Yann Ylavic
On Wed, Sep 2, 2015 at 7:54 PM, Stefan Eissing wrote: > If we want to be more safe, we can change the Protocols default to just > http/1.1. Also the default for ordering we can change, np. > > Other opinions? Thanks, LGTM (though I like the idea of ap_select_protocol() returning a different valu

Re: svn commit: r1695727 - in /httpd/httpd/trunk: docs/manual/mod/core.xml include/http_core.h server/core.c server/protocol.c

2015-09-02 Thread Stefan Eissing
If we want to be more safe, we can change the Protocols default to just http/1.1. Also the default for ordering we can change, np. Other opinions? For ALPN, afaik the callback only gets triggered if the client actually sends ALPN in its hello. Since "http/1.1" is the only identifier defined i

Re: svn commit: r1695727 - in /httpd/httpd/trunk: docs/manual/mod/core.xml include/http_core.h server/core.c server/protocol.c

2015-09-02 Thread Stefan Eissing
We can choose any string we want, but for ALPN negotiation there is only http/1.1 defined. We could of course translate that but then we need to explain somewhere what we mean by it. For the Upgrade case, we could ap_get_protocol make return exactly what the client sent us. But accomodating for

Re: svn commit: r1695727 - in /httpd/httpd/trunk: docs/manual/mod/core.xml include/http_core.h server/core.c server/protocol.c

2015-09-02 Thread William A Rowe Jr
On Wed, Sep 2, 2015 at 11:20 AM, Yann Ylavic wrote: > > It is not clear to me (still, see [1]) why Protocols would default > like this, and h2 be available for all the vhosts (provided mod_http2 > is loaded) unless the above is configured. > IOW, I'd prefer "Protocols http/1.1" to be the default

Re: svn commit: r1695727 - in /httpd/httpd/trunk: docs/manual/mod/core.xml include/http_core.h server/core.c server/protocol.c

2015-09-02 Thread Eric Covener
On Wed, Sep 2, 2015 at 12:20 PM, Yann Ylavic wrote: > Again here I'd suggest "On" by default (eg. SSLHonorCipherOrder is > quite recommended today, if that's a valid analogy). +1 -- Eric Covener cove...@gmail.com

Re: svn commit: r1695727 - in /httpd/httpd/trunk: docs/manual/mod/core.xml include/http_core.h server/core.c server/protocol.c

2015-09-02 Thread Yann Ylavic
On Thu, Aug 13, 2015 at 5:33 PM, wrote: > Author: icing > Date: Thu Aug 13 15:33:07 2015 > New Revision: 1695727 > > URL: http://svn.apache.org/r1695727 > Log: > new directive ProtocolsHonorOrder, added documentation for Protocols feature, > changed preference selection and config merging > > Mo