Re: svn commit: r1732986 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2016-03-01 Thread Yann Ylavic
On Tue, Mar 1, 2016 at 1:26 PM, Plüm, Rüdiger, Vodafone Group wrote: > >> From: Jim Jagielski [mailto:j...@jagunet.com] >> >> I'd prefer we use a define, eg: >> >> #define PROXY_WORKER_RFC1035_SIZE 512 >> >> rather than embedding magic numbers... > > +1 Agreed, much better, committed in r1733056.

RE: svn commit: r1732986 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2016-03-01 Thread Plüm , Rüdiger , Vodafone Group
> -Original Message- > From: Jim Jagielski [mailto:j...@jagunet.com] > Sent: Dienstag, 1. März 2016 12:58 > To: dev@httpd.apache.org > Cc: c...@httpd.apache.org > Subject: Re: svn commit: r1732986 - > /httpd/httpd/trunk/modules/proxy/proxy_util.c > > I&#

Re: svn commit: r1732986 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2016-03-01 Thread Jim Jagielski
I'd prefer we use a define, eg: #define PROXY_WORKER_RFC1035_SIZE 512 rather than embedding magic numbers... > On Feb 29, 2016, at 8:20 PM, yla...@apache.org wrote: > > Author: ylavic > Date: Tue Mar 1 01:20:06 2016 > New Revision: 1732986 > > URL: http://svn.apache.org/viewvc?rev=1732986&vie