Re: svn commit: r1740928 - in /httpd/httpd/trunk: ./ include/ modules/http2/ modules/proxy/ modules/ssl/ server/

2017-10-14 Thread Yann Ylavic
Committed something with explanations (hopefully) in r1812193. Does it sound good? On Thu, Oct 12, 2017 at 3:54 AM, William A Rowe Jr wrote: > I will review again tomorrow. > > My jump-around idea was to check against all of the bits in not dir loc > file, and if the

Re: svn commit: r1740928 - in /httpd/httpd/trunk: ./ include/ modules/http2/ modules/proxy/ modules/ssl/ server/

2017-10-11 Thread William A Rowe Jr
I will review again tomorrow. My jump-around idea was to check against all of the bits in not dir loc file, and if the module's MMN minor is too early, treat the section as if that bit is set. On Oct 11, 2017 16:13, "Yann Ylavic" wrote: On Wed, Oct 11, 2017 at 11:02

Re: svn commit: r1740928 - in /httpd/httpd/trunk: ./ include/ modules/http2/ modules/proxy/ modules/ssl/ server/

2017-10-11 Thread Yann Ylavic
On Wed, Oct 11, 2017 at 11:02 PM, Yann Ylavic wrote: > On Wed, Oct 11, 2017 at 10:49 PM, Yann Ylavic wrote: >> On Wed, Oct 11, 2017 at 10:38 PM, Yann Ylavic wrote: >>> >>> Thus, how about if there, for 2.4.x only (i.e. backport

Re: svn commit: r1740928 - in /httpd/httpd/trunk: ./ include/ modules/http2/ modules/proxy/ modules/ssl/ server/

2017-10-11 Thread Yann Ylavic
On Wed, Oct 11, 2017 at 10:49 PM, Yann Ylavic wrote: > On Wed, Oct 11, 2017 at 10:38 PM, Yann Ylavic wrote: >> >> Thus, how about if there, for 2.4.x only (i.e. backport patch), we'd >> instead check for: >>> +|| (((forbidden & NOT_IN_PROXY)

Re: svn commit: r1740928 - in /httpd/httpd/trunk: ./ include/ modules/http2/ modules/proxy/ modules/ssl/ server/

2017-10-11 Thread Yann Ylavic
On Wed, Oct 11, 2017 at 10:38 PM, Yann Ylavic wrote: > > Thus, how about if there, for 2.4.x only (i.e. backport patch), we'd > instead check for: >> +|| (((forbidden & NOT_IN_PROXY) >> + || (forbidden & NOT_IN_DIR_LOC_FILE) == NOT_IN_DIR_LOC_FILE >> +

Re: svn commit: r1740928 - in /httpd/httpd/trunk: ./ include/ modules/http2/ modules/proxy/ modules/ssl/ server/

2017-10-11 Thread Yann Ylavic
On Wed, Oct 11, 2017 at 5:15 PM, William A Rowe Jr wrote: >> >> +#define NOT_IN_PROXY 0x40 /**< Forbidden in Proxy */ >> +/** Forbidden in >> Directory/Location/FilesIfProxy*/ >> +#define NOT_IN_DIR_LOC_FILE >>

Re: svn commit: r1740928 - in /httpd/httpd/trunk: ./ include/ modules/http2/ modules/proxy/ modules/ssl/ server/

2017-10-11 Thread William A Rowe Jr
On Mon, Apr 25, 2016 at 7:04 PM, wrote: > Author: ylavic > Date: Tue Apr 26 00:04:57 2016 > New Revision: 1740928 > > URL: http://svn.apache.org/viewvc?rev=1740928=rev > Log: > mod_proxy, mod_ssl: Handle SSLProxy* directives in sections, > allowing different TLS

Re: svn commit: r1740928 - in /httpd/httpd/trunk: ./ include/ modules/http2/ modules/proxy/ modules/ssl/ server/

2016-08-19 Thread Yann Ylavic
On Fri, Aug 19, 2016 at 5:49 PM, William A Rowe Jr wrote: > Additional issues since this patch in our maintainer mode... > > httpd-2.x/modules/ssl/ssl_engine_config.c: In function > 'ssl_cmd_SSLVerifyClient': > httpd-2.x/modules/ssl/ssl_engine_config.c:1083:27: warning:

Re: svn commit: r1740928 - in /httpd/httpd/trunk: ./ include/ modules/http2/ modules/proxy/ modules/ssl/ server/

2016-08-19 Thread William A Rowe Jr
Additional issues since this patch in our maintainer mode... httpd-2.x/modules/ssl/ssl_engine_config.c: In function 'ssl_cmd_SSLVerifyClient': httpd-2.x/modules/ssl/ssl_engine_config.c:1083:27: warning: 'mode' may be used uninitialized in this function [-Wmaybe-uninitialized]

Re: svn commit: r1740928 - in /httpd/httpd/trunk: ./ include/ modules/http2/ modules/proxy/ modules/ssl/ server/

2016-04-26 Thread Yann Ylavic
On Tue, Apr 26, 2016 at 11:00 AM, Ruediger Pluem wrote: > > On 04/26/2016 02:04 AM, yla...@apache.org wrote: >> static int ssl_hook_pre_connection(conn_rec *c, void *csd) >> { >> - >> SSLSrvConfigRec *sc; >> SSLConnRec *sslconn = myConnConfig(c); >> >> -if

Re: svn commit: r1740928 - in /httpd/httpd/trunk: ./ include/ modules/http2/ modules/proxy/ modules/ssl/ server/

2016-04-26 Thread Ruediger Pluem
On 04/26/2016 02:04 AM, yla...@apache.org wrote: > Author: ylavic > Date: Tue Apr 26 00:04:57 2016 > New Revision: 1740928 > > URL: http://svn.apache.org/viewvc?rev=1740928=rev > Log: > mod_proxy, mod_ssl: Handle SSLProxy* directives in sections, > allowing different TLS configurations per