Re: svn commit: r1745517 - /httpd/httpd/branches/2.4.x/support/win32/ApacheMonitor.c

2016-05-25 Thread Gregg Smith
On 5/25/2016 11:14 AM, William A Rowe Jr wrote: Your comment doesn't match the code, and I think you have the condition inverted, _setargv() worked for decades, and only was broken in the more recent MSVC's. Typo, should be 1800 in log, I'll change it. I may revert it now that I dug & found

Re: svn commit: r1745517 - /httpd/httpd/branches/2.4.x/support/win32/ApacheMonitor.c

2016-05-25 Thread William A Rowe Jr
On Wed, May 25, 2016 at 1:14 PM, William A Rowe Jr wrote: > Your comment doesn't match the code, and I think you have the condition > inverted, _setargv() worked for decades, and only was broken in the more > recent MSVC's. > Correction, the code looks right (sort of, I

Re: svn commit: r1745517 - /httpd/httpd/branches/2.4.x/support/win32/ApacheMonitor.c

2016-05-25 Thread William A Rowe Jr
Your comment doesn't match the code, and I think you have the condition inverted, _setargv() worked for decades, and only was broken in the more recent MSVC's. My thought is to unilaterally change this to the unicode implementation, because 1. ANSI-only are dead Windows OS's, and 2. Getting the