Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

2016-08-12 10:27 GMT+02:00 Luca Toscano : > > > 2016-08-11 18:14 GMT+02:00 William A Rowe Jr : > >> Hi Luca, >> >> it helps at this point in the discussions to post the delta to >> branches/2.4.x, >> for all of us to see the delta between 'current' and

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

Hi Luca, it helps at this point in the discussions to post the delta to branches/2.4.x, for all of us to see the delta between 'current' and 'prospective' behaviors, and ignoring the status of trunk for the moment. Attached is that delta... On Thu, Aug 11, 2016 at 5:49 AM, Luca Toscano

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

2016-08-04 11:52 GMT+02:00 Luca Toscano : > > > 2016-08-02 10:17 GMT+02:00 Luca Toscano : > >> >> 2016-08-01 21:13 GMT+02:00 Jacob Champion >>> >>> >>> As stated above, this is not my first choice -- but I wouldn't oppose it

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

2016-08-02 10:17 GMT+02:00 Luca Toscano : > > 2016-08-01 21:13 GMT+02:00 Jacob Champion >> >> >> As stated above, this is not my first choice -- but I wouldn't oppose it >> if that's what the consensus comes to. >> >> else if

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

2016-08-01 21:13 GMT+02:00 Jacob Champion > > > As stated above, this is not my first choice -- but I wouldn't oppose it > if that's what the consensus comes to. > > else if (!ap_cstr_casecmp(w, "Last-Modified")) { >> -apr_time_t parsed_date =

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

On 08/01/2016 01:35 PM, William A Rowe Jr wrote: > I do like your argument that we should do as little transformation > as possible, in order to facilitate moving CGI apps between > environments. Implementation differences are nasty for everyone. But > I'm not convinced that ship hasn't sailed;

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

On Mon, Aug 1, 2016 at 2:13 PM, Jacob Champion wrote: > All right, getting back to this after a week off. I've tried to combine > feedback as best I can into one message. > > Bill, you wrote: > > I'm perfectly happy to translate such values to GMT for non-HTTP >> inputs,

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

On Mon, Aug 1, 2016 at 3:03 PM, Jacob Champion wrote: > On 08/01/2016 12:38 PM, William A Rowe Jr wrote: > >> I'll review the rest of your comments shortly, but you might want to >> review >> https://tools.ietf.org/html/rfc3875 before claiming CGI isn't an HTTP >> input :-)

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

On 08/01/2016 12:38 PM, William A Rowe Jr wrote: I'll review the rest of your comments shortly, but you might want to review https://tools.ietf.org/html/rfc3875 before claiming CGI isn't an HTTP input :-) I suspect we're talking past each other at this point. I'm aware of 3875 (though I don't

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

On Mon, Aug 1, 2016 at 2:13 PM, Jacob Champion wrote: > All right, getting back to this after a week off. I've tried to combine > feedback as best I can into one message. > > Bill, you wrote: > > I'm perfectly happy to translate such values to GMT for non-HTTP >> inputs,

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

All right, getting back to this after a week off. I've tried to combine feedback as best I can into one message. Bill, you wrote: I'm perfectly happy to translate such values to GMT for non-HTTP inputs, per spec. If we are going to do so for HTTP inputs, loudly scolding the errant developer

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

2016-07-29 10:30 GMT+02:00 Stefan Eissing : > > > Am 28.07.2016 um 18:50 schrieb William A Rowe Jr : > > > > On Thu, Jul 28, 2016 at 10:29 AM, Luca Toscano > wrote: > > > > I'd really like to have more opinions from other

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

> Am 28.07.2016 um 18:50 schrieb William A Rowe Jr : > > On Thu, Jul 28, 2016 at 10:29 AM, Luca Toscano wrote: > > I'd really like to have more opinions from other readers of the list.. > > ++1, we've presented our thoughts, it would be good to

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

On Thu, Jul 28, 2016 at 10:29 AM, Luca Toscano wrote: > I'd really like to have more opinions from other readers of the list.. > ++1, we've presented our thoughts, it would be good to have others chime in.

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

2016-07-28 16:05 GMT+02:00 William A Rowe Jr : > On Thu, Jul 28, 2016 at 8:25 AM, Luca Toscano > wrote: > >> >> The first version of the change tried to solve an actual bug imho, namely >> returning Last-Modified: Thu, 01 Jan 1970 00:00:00 GMT when

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

On Thu, Jul 28, 2016 at 8:25 AM, Luca Toscano wrote: > > The first version of the change tried to solve an actual bug imho, namely > returning Last-Modified: Thu, 01 Jan 1970 00:00:00 GMT when the FCGI > backend returned something like Last-Modified: bad-value-here (more

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

2016-07-27 20:26 GMT+02:00 William A Rowe Jr : > On Wed, Jul 27, 2016 at 1:18 PM, Luca Toscano > wrote: > >> >> 2016-07-25 14:41 GMT+02:00 Yann Ylavic : >> >>> On Fri, Jul 22, 2016 at 8:42 PM, Jacob Champion

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

On Wed, Jul 27, 2016 at 1:18 PM, Luca Toscano wrote: > > 2016-07-25 14:41 GMT+02:00 Yann Ylavic : > >> On Fri, Jul 22, 2016 at 8:42 PM, Jacob Champion >> wrote: >> > On 07/22/2016 10:49 AM, William A Rowe Jr wrote: >> >> >> >>

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

2016-07-25 14:41 GMT+02:00 Yann Ylavic : > On Fri, Jul 22, 2016 at 8:42 PM, Jacob Champion > wrote: > > On 07/22/2016 10:49 AM, William A Rowe Jr wrote: > >> > >> I'm -1 for interpretating invalid values. > > > > > > By "invalid" do you mean any string

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

On Fri, Jul 22, 2016 at 8:42 PM, Jacob Champion wrote: > On 07/22/2016 10:49 AM, William A Rowe Jr wrote: >> >> I'm -1 for interpretating invalid values. > > > By "invalid" do you mean any string that doesn't comply with 723x's > Last-Modified definition? Even if the only

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

2016-07-23 1:18 GMT+02:00 Jacob Champion : > On 07/22/2016 01:38 PM, William A Rowe Jr wrote: > >> RFC 7231 § 7.1.1 >> RFC 7232 § 2.2 >> > > Okay, at least we're looking at the same sections then. But I'm not > finding support for your statement that we must replace

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

On 07/22/2016 01:38 PM, William A Rowe Jr wrote: RFC 7231 § 7.1.1 RFC 7232 § 2.2 Okay, at least we're looking at the same sections then. But I'm not finding support for your statement that we must replace completely unintelligible Last-Modified values with current timestamps. The closest I

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

RFC 7231 § 7.1.1 RFC 7232 § 2.2 On Jul 22, 2016 15:01, "Jacob Champion" wrote: > On 07/22/2016 12:30 PM, William A Rowe Jr wrote: > >> Yes, I mean anything that doesn't fit one of the *three* allowable >> formats. >> Nothing is allowed except for GMT. >> > > Agreed, only

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

On 07/22/2016 12:30 PM, William A Rowe Jr wrote: Yes, I mean anything that doesn't fit one of the *three* allowable formats. Nothing is allowed except for GMT. Agreed, only GMT is allowed on the wire. I still believe it's potentially useful, and not unsafe, to transform a non-GMT timestamp

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

On Fri, Jul 22, 2016 at 1:42 PM, Jacob Champion wrote: > On 07/22/2016 10:49 AM, William A Rowe Jr wrote: > >> I'm -1 for interpretating invalid values. >> > > By "invalid" do you mean any string that doesn't comply with 723x's > Last-Modified definition? Even if the only

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

On 07/22/2016 10:49 AM, William A Rowe Jr wrote: I'm -1 for interpretating invalid values. By "invalid" do you mean any string that doesn't comply with 723x's Last-Modified definition? Even if the only non-compliance is the use of a non-GMT timezone? I'm not personally a fan of all the

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

I'm -1 for interpretating invalid values. But +1 for alerting the admin of the invalid script/module/CGI. The new behavior was wrong, it should be set to now() for all invalid input IMHO On Jul 21, 2016 5:20 PM, "Jacob Champion" wrote: > On 07/03/2016 02:56 AM, Luca

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

On 07/03/2016 02:56 AM, Luca Toscano wrote: Patch committed to trunk in http://svn.apache.org/r1751138 Updated backport proposal and trunk's CHANGES. Attached is an httpd-test patch with some regression cases for this change. (I'm not sure what the review/commit policies are for that repo;

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

2016-07-02 18:27 GMT+02:00 Yann Ylavic : > On Sat, Jul 2, 2016 at 4:39 PM, William A Rowe Jr > wrote: > > Relevant data points... > > > > https://tools.ietf.org/html/rfc7231#section-7.1.1.1 > > > > There is no other supported time zone except GMT

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

On Sat, Jul 2, 2016 at 4:39 PM, William A Rowe Jr wrote: > Relevant data points... > > https://tools.ietf.org/html/rfc7231#section-7.1.1.1 > > There is no other supported time zone except GMT representing GMT. That is > the only value we may send. > > "Recipients of

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

Relevant data points... https://tools.ietf.org/html/rfc7231#section-7.1.1.1 There is no other supported time zone except GMT representing GMT. That is the only value we may send. "Recipients of timestamp values are encouraged to be robust in parsing timestamps unless otherwise restricted by

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

On Sat, Jul 2, 2016 at 2:05 AM, Luca Toscano wrote: > > We have discussed it briefly in another email but didn't reach a conclusion, > so I am really happy to re-discuss it again. Maybe an example would clarify > what a user will see in the logs. How about (modulo quick,

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

2016-07-01 22:31 GMT+02:00 Yann Ylavic : > On Fri, Jul 1, 2016 at 10:17 PM, William A Rowe Jr > wrote: > > On Fri, Jul 1, 2016 at 2:58 PM, Yann Ylavic > wrote: > >> > >> On Fri, Jul 1, 2016 at 6:32 PM, Luca Toscano

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

On Fri, Jul 1, 2016 at 10:17 PM, William A Rowe Jr wrote: > On Fri, Jul 1, 2016 at 2:58 PM, Yann Ylavic wrote: >> >> On Fri, Jul 1, 2016 at 6:32 PM, Luca Toscano >> wrote: >> > >> > "The Last-Modified header value '%s' (parsed

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

On Fri, Jul 1, 2016 at 2:58 PM, Yann Ylavic wrote: > On Fri, Jul 1, 2016 at 6:32 PM, Luca Toscano > wrote: > > > > "The Last-Modified header value '%s' (parsed assuming the GMT timezone) > has > > been replaced with '%s' because considered in the

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

On Fri, Jul 1, 2016 at 6:32 PM, Luca Toscano wrote: > > "The Last-Modified header value '%s' (parsed assuming the GMT timezone) has > been replaced with '%s' because considered in the future." Looks good to me (maybe "(GMT)" only between parentheses?). The original log

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

Hi Yann! 2016-07-01 18:02 GMT+02:00 Yann Ylavic : > On Fri, Jul 1, 2016 at 5:00 PM, wrote: > > Author: elukey > > Date: Fri Jul 1 15:00:42 2016 > > New Revision: 1750953 > > > > URL: http://svn.apache.org/viewvc?rev=1750953=rev > > Log: > > Fixed typo

Re: svn commit: r1750953 - /httpd/httpd/trunk/server/util_script.c

On Fri, Jul 1, 2016 at 5:00 PM, wrote: > Author: elukey > Date: Fri Jul 1 15:00:42 2016 > New Revision: 1750953 > > URL: http://svn.apache.org/viewvc?rev=1750953=rev > Log: > Fixed typo in log message, wrong RFC mentioned. > > Modified: >