Re: svn commit: r1768245 - /httpd/httpd/trunk/modules/cache/mod_socache_memcache.c

2016-11-21 Thread Jim Jagielski
IMO, if you use and compute something 2x or more, it should be a var. YMMV > On Nov 18, 2016, at 4:04 PM, Christophe JAILLET > wrote: > > Le 05/11/2016 à 17:47, j...@apache.org a écrit : >> Author: jim >> Date: Sat Nov 5 16:47:43 2016 >> New Revision: 1768245 >>

Re: svn commit: r1768245 - /httpd/httpd/trunk/modules/cache/mod_socache_memcache.c

2016-11-18 Thread Christophe JAILLET
Le 05/11/2016 à 17:47, j...@apache.org a écrit : Author: jim Date: Sat Nov 5 16:47:43 2016 New Revision: 1768245 URL: http://svn.apache.org/viewvc?rev=1768245=rev Log: heh... bring memcache up to redis :) mod_status info Modified: httpd/httpd/trunk/modules/cache/mod_socache_memcache.c

Re: svn commit: r1768245 - /httpd/httpd/trunk/modules/cache/mod_socache_memcache.c

2016-11-06 Thread William A Rowe Jr
On Sun, Nov 6, 2016 at 1:45 PM, Jim Jagielski wrote: > Why? We trust the apr_memcache.c returns the correct > response... No need to check the version of APR or > APU since mod_socache_memcache.c works fine no > matter what version is used. I missed that this is a trunk/2.4

Re: svn commit: r1768245 - /httpd/httpd/trunk/modules/cache/mod_socache_memcache.c

2016-11-06 Thread Jim Jagielski
Why? We trust the apr_memcache.c returns the correct response... No need to check the version of APR or APU since mod_socache_memcache.c works fine no matter what version is used. > On Nov 6, 2016, at 11:58 AM, William A Rowe Jr wrote: > > > On Sun, Nov 6, 2016 at 10:57

Re: svn commit: r1768245 - /httpd/httpd/trunk/modules/cache/mod_socache_memcache.c

2016-11-06 Thread William A Rowe Jr
On Sun, Nov 6, 2016 at 10:57 AM, William A Rowe Jr wrote: > Wrap this up in an #if APU_MAJOR_VERSION > 1 || APU_MINOR_VERSION > 6 > > before backporting? (Yes - these symbols will still exist in unifed APR2 > and later.) > #if APU_MAJOR_VERSION > 1 || APU_MINOR_VERSION >= 6

Re: svn commit: r1768245 - /httpd/httpd/trunk/modules/cache/mod_socache_memcache.c

2016-11-06 Thread William A Rowe Jr
Wrap this up in an #if APU_MAJOR_VERSION > 1 || APU_MINOR_VERSION > 6 before backporting? (Yes - these symbols will still exist in unifed APR2 and later.) Since we can't demand users update apr to pick up 2.4.next, and some will be using the OS-deployed APR. On Nov 5, 2016 11:47 AM,