Re: svn commit: r1782986 - /httpd/httpd/trunk/server/util_filter.c

2020-07-06 Thread Marion & Christophe JAILLET
Thx for both of you for the explanation. Le 06/07/2020 à 11:56, Yann Ylavic a écrit : [...] Finally APR_BUCKET_IS_{EOS,}(e) on an EMPTY brigade is always false with the current struct apr_bucket_brigade API. That's also my understanding. That is what was puzzling me. Just a bit fragile :)

Re: svn commit: r1782986 - /httpd/httpd/trunk/server/util_filter.c

2020-07-06 Thread Yann Ylavic
On Mon, Jul 6, 2020 at 11:56 AM Yann Ylavic wrote: > > > > In the previous code the first condition in the if was always true, and I > > am not sure what happened with the second condition in > > case e was the sentinel. > > AIUI, dereferencing the SENTINEL is not accessing unreserved/freed >

Re: svn commit: r1782986 - /httpd/httpd/trunk/server/util_filter.c

2020-07-06 Thread Yann Ylavic
On Mon, Jul 6, 2020 at 8:44 AM Ruediger Pluem wrote: > > On 7/5/20 9:29 AM, Christophe JAILLET wrote: > > > > Le 14/02/2017 à 17:43, yla...@apache.org a écrit : > >> @@ -584,9 +584,9 @@ AP_DECLARE(apr_status_t) ap_pass_brigade > >>apr_bucket_brigade

Re: svn commit: r1782986 - /httpd/httpd/trunk/server/util_filter.c

2020-07-06 Thread Ruediger Pluem
On 7/5/20 9:29 AM, Christophe JAILLET wrote: > Le 14/02/2017 à 17:43, yla...@apache.org a écrit : >> Author: ylavic >> Date: Tue Feb 14 16:43:25 2017 >> New Revision: 1782986 >> >> URL:http://svn.apache.org/viewvc?rev=1782986=rev >> Log: >> util_filter: better ap_pass_brigade() vs empty

Re: svn commit: r1782986 - /httpd/httpd/trunk/server/util_filter.c

2020-07-05 Thread Christophe JAILLET
Le 14/02/2017 à 17:43, yla...@apache.org a écrit : Author: ylavic Date: Tue Feb 14 16:43:25 2017 New Revision: 1782986 URL:http://svn.apache.org/viewvc?rev=1782986=rev Log: util_filter: better ap_pass_brigade() vs empty brigades. Modified: httpd/httpd/trunk/server/util_filter.c Modified: