Re: svn commit: r1836239 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_request.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/mpm/simple/simple_io.c server/util_filter.c

2018-07-20 Thread Yann Ylavic
On Fri, Jul 20, 2018 at 4:01 PM, Ruediger Pluem wrote: > > You describe the inconsistency in case c->data_in_input_filters is 1, > I did for the case that c->data_in_input_filters is 0, but yes we could have > inconsistencies in both cases > and the question is if they are always fine. So far it

Re: svn commit: r1836239 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_request.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/mpm/simple/simple_io.c server/util_filter.c

2018-07-20 Thread Ruediger Pluem
On 07/20/2018 03:49 PM, Yann Ylavic wrote: > On Fri, Jul 20, 2018 at 2:54 PM, Ruediger Pluem wrote: >> >> On 07/20/2018 02:38 PM, Yann Ylavic wrote: >>> On Fri, Jul 20, 2018 at 12:08 PM, Ruediger Pluem wrote: On 07/19/2018 12:36 AM, yla...@apache.org wrote: > > -if

Re: svn commit: r1836239 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_request.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/mpm/simple/simple_io.c server/util_filter.c

2018-07-20 Thread Yann Ylavic
On Fri, Jul 20, 2018 at 2:54 PM, Ruediger Pluem wrote: > > On 07/20/2018 02:38 PM, Yann Ylavic wrote: >> On Fri, Jul 20, 2018 at 12:08 PM, Ruediger Pluem wrote: >>> >>> On 07/19/2018 12:36 AM, yla...@apache.org wrote: -if (!c->data_in_input_filters || ap_run_input_pending(c) != OK)

Re: svn commit: r1836239 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_request.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/mpm/simple/simple_io.c server/util_filter.c

2018-07-20 Thread Ruediger Pluem
On 07/20/2018 02:38 PM, Yann Ylavic wrote: > On Fri, Jul 20, 2018 at 12:08 PM, Ruediger Pluem wrote: >> >> On 07/19/2018 12:36 AM, yla...@apache.org wrote: >>> >>> -if (!c->data_in_input_filters || ap_run_input_pending(c) != OK) { >>> +if (ap_run_input_pending(c) != OK) { >> >> We have

Re: svn commit: r1836239 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_request.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/mpm/simple/simple_io.c server/util_filter.c

2018-07-20 Thread Yann Ylavic
On Fri, Jul 20, 2018 at 12:08 PM, Ruediger Pluem wrote: > > On 07/19/2018 12:36 AM, yla...@apache.org wrote: >> >> -if (!c->data_in_input_filters || ap_run_input_pending(c) != OK) { >> +if (ap_run_input_pending(c) != OK) { > > We have a different code flow here now. If

Re: svn commit: r1836239 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_request.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/mpm/simple/simple_io.c server/util_filter.c

2018-07-20 Thread Ruediger Pluem
On 07/19/2018 12:36 AM, yla...@apache.org wrote: > Author: ylavic > Date: Wed Jul 18 22:36:19 2018 > New Revision: 1836239 > > URL: http://svn.apache.org/viewvc?rev=1836239=rev > Log: > core: integrate data_in_{in,out}put_filter to ap_filter_{in,out}put_pending(). > > Straightforward for