On Thu, Apr 02, 2020 at 10:37:01AM +0200, Ruediger Pluem wrote:
> Sounds reasonable. Thanks for explaining. Do you fix <= vs < and > vs >= or
> should I?
http://svn.apache.org/viewvc?view=revision&revision=1876037
I hope I have tweaked this to death now, but more review definitely
welcome since
On 4/2/20 9:36 AM, Joe Orton wrote:
> On Thu, Apr 02, 2020 at 07:30:50AM +0200, Ruediger Pluem wrote:
>> On 4/1/20 11:44 PM, Mike Rumph wrote:
>>> I'm not very familiar with this code, so my questions might not make sense.
>>>
>>> But take a look at the following two code segments in
>>> ssl_io
On Thu, Apr 02, 2020 at 07:30:50AM +0200, Ruediger Pluem wrote:
> On 4/1/20 11:44 PM, Mike Rumph wrote:
> > I'm not very familiar with this code, so my questions might not make sense.
> >
> > But take a look at the following two code segments in
> > ssl_io_filter_coalesce():
> >
> > for (e =
On 4/1/20 11:44 PM, Mike Rumph wrote:
> I'm not very familiar with this code, so my questions might not make sense.
>
> But take a look at the following two code segments in
> ssl_io_filter_coalesce():
>
> for (e = APR_BRIGADE_FIRST(bb);
> e != APR_BRIGADE_SENTINEL(bb)
>
I'm not very familiar with this code, so my questions might not make sense.
But take a look at the following two code segments in
ssl_io_filter_coalesce():
for (e = APR_BRIGADE_FIRST(bb);
e != APR_BRIGADE_SENTINEL(bb)
&& !APR_BUCKET_IS_METADATA(e)
&& e->leng
On 4/1/20 2:38 PM, Joe Orton wrote:
> On Wed, Apr 01, 2020 at 02:04:21PM +0200, Ruediger Pluem wrote:
>> On 3/30/20 3:18 PM, jor...@apache.org wrote:
>>>
>>> -rv = apr_bucket_split(e, COALESCE_BYTES - (buffered + bytes));
>>> +/* If the read above made the bucket morph, it may
On Wed, Apr 1, 2020 at 2:39 PM Joe Orton wrote:
>
> On Wed, Apr 01, 2020 at 02:04:21PM +0200, Ruediger Pluem wrote:
> > On 3/30/20 3:18 PM, jor...@apache.org wrote:
> > >
> > > -rv = apr_bucket_split(e, COALESCE_BYTES - (buffered + bytes));
> > > +/* If the read above made the buck
On Wed, Apr 01, 2020 at 02:04:21PM +0200, Ruediger Pluem wrote:
> On 3/30/20 3:18 PM, jor...@apache.org wrote:
> >
> > -rv = apr_bucket_split(e, COALESCE_BYTES - (buffered + bytes));
> > +/* If the read above made the bucket morph, it may now fit
> > + * entirely within th
On 3/30/20 3:18 PM, jor...@apache.org wrote:
> Author: jorton
> Date: Mon Mar 30 13:18:29 2020
> New Revision: 1875881
>
> URL: http://svn.apache.org/viewvc?rev=1875881&view=rev
> Log:
> * modules/ssl/ssl_engine_io.c: (ssl_io_filter_coalesce): Handle the
> case of a bucket which morphs to a b
