Re: svn commit: r1879488 - /httpd/httpd/trunk/server/util_etag.c

2020-07-06 Thread Yann Ylavic
On Mon, Jul 6, 2020 at 12:37 PM Graham Leggett wrote: > > On 06 Jul 2020, at 09:28, Ruediger Pluem wrote: > > +apr_sha1_init(); > +nbytes = sizeof(buf); > +while ((status = apr_file_read(fd, buf, )) == APR_SUCCESS) { > > > Why do we still use apr_file_read in case we use MMAP? IMHO

Re: svn commit: r1879488 - /httpd/httpd/trunk/server/util_etag.c

2020-07-06 Thread Graham Leggett
On 06 Jul 2020, at 09:28, Ruediger Pluem wrote: >> +apr_sha1_init(); >> +nbytes = sizeof(buf); >> +while ((status = apr_file_read(fd, buf, )) == APR_SUCCESS) { > > Why do we still use apr_file_read in case we use MMAP? IMHO we should use > apr_mmap_offset. > But we would need to

Re: svn commit: r1879488 - /httpd/httpd/trunk/server/util_etag.c

2020-07-06 Thread Ruediger Pluem
On 7/3/20 9:48 PM, minf...@apache.org wrote: > Author: minfrin > Date: Fri Jul 3 19:48:53 2020 > New Revision: 1879488 > > URL: http://svn.apache.org/viewvc?rev=1879488=rev > Log: > Add MMAP support to ETag generation. > > Modified: > httpd/httpd/trunk/server/util_etag.c > > Modified: