Re: svn commit: r1914067 - in /httpd/httpd/trunk: changes-entries/ldap-optimise.txt modules/aaa/mod_authnz_ldap.c

2023-11-24 Thread Yann Ylavic
On Thu, Nov 23, 2023 at 3:00 PM Ruediger Pluem wrote: > > On 11/23/23 2:28 PM, Yann Ylavic wrote: > > On Thu, Nov 23, 2023 at 1:33 PM Ruediger Pluem wrote: > >> > >> > >> > >> On 11/23/23 12:52 PM, Graham Leggett via dev wrote: > >>> On 23 Nov 2023, at 11:25, Ruediger Pluem wrote: > >>> > >

Re: svn commit: r1914067 - in /httpd/httpd/trunk: changes-entries/ldap-optimise.txt modules/aaa/mod_authnz_ldap.c

2023-11-24 Thread Yann Ylavic
On Thu, Nov 23, 2023 at 11:06 PM Graham Leggett via dev wrote: > > On 23 Nov 2023, at 13:28, Yann Ylavic wrote: > > Unfortunately the message is correct and we do just that via > get_dn_for_nonldap_authn (line 1451). The DN you mention we look for > later in line 1480 via

Re: svn commit: r1914067 - in /httpd/httpd/trunk: changes-entries/ldap-optimise.txt modules/aaa/mod_authnz_ldap.c

2023-11-23 Thread Graham Leggett via dev
On 23 Nov 2023, at 13:28, Yann Ylavic wrote: >> Unfortunately the message is correct and we do just that via >> get_dn_for_nonldap_authn (line 1451). The DN you mention we look for >> later in line 1480 via util_ldap_cache_getuserdn. > > My guess was that if r->user is set we always want to

Re: svn commit: r1914067 - in /httpd/httpd/trunk: changes-entries/ldap-optimise.txt modules/aaa/mod_authnz_ldap.c

2023-11-23 Thread Ruediger Pluem
On 11/23/23 2:28 PM, Yann Ylavic wrote: > On Thu, Nov 23, 2023 at 1:33 PM Ruediger Pluem wrote: >> >> >> >> On 11/23/23 12:52 PM, Graham Leggett via dev wrote: >>> On 23 Nov 2023, at 11:25, Ruediger Pluem wrote: >>> > -if (req->dn == NULL || !*req->dn) { > -

Re: svn commit: r1914067 - in /httpd/httpd/trunk: changes-entries/ldap-optimise.txt modules/aaa/mod_authnz_ldap.c

2023-11-23 Thread Yann Ylavic
On Thu, Nov 23, 2023 at 1:33 PM Ruediger Pluem wrote: > > > > On 11/23/23 12:52 PM, Graham Leggett via dev wrote: > > On 23 Nov 2023, at 11:25, Ruediger Pluem wrote: > > > >>> -if (req->dn == NULL || !*req->dn) { > >>> -ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, APLOGNO(02636) >

Re: svn commit: r1914067 - in /httpd/httpd/trunk: changes-entries/ldap-optimise.txt modules/aaa/mod_authnz_ldap.c

2023-11-23 Thread Ruediger Pluem
On 11/23/23 12:52 PM, Graham Leggett via dev wrote: > On 23 Nov 2023, at 11:25, Ruediger Pluem wrote: > >>> -    if (req->dn == NULL || !*req->dn) { >>> -    ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, APLOGNO(02636) >>> -  "auth_ldap authorize: require ldap-filter:

Re: svn commit: r1914067 - in /httpd/httpd/trunk: changes-entries/ldap-optimise.txt modules/aaa/mod_authnz_ldap.c

2023-11-23 Thread Graham Leggett via dev
On 23 Nov 2023, at 11:25, Ruediger Pluem wrote: >> -if (req->dn == NULL || !*req->dn) { >> -ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, APLOGNO(02636) >> - "auth_ldap authorize: require ldap-filter: user's DN " >> - "has not been defined;

Re: svn commit: r1914067 - in /httpd/httpd/trunk: changes-entries/ldap-optimise.txt modules/aaa/mod_authnz_ldap.c

2023-11-23 Thread Ruediger Pluem
On 11/23/23 11:22 AM, minf...@apache.org wrote: > Author: minfrin > Date: Thu Nov 23 10:22:58 2023 > New Revision: 1914067 > > URL: http://svn.apache.org/viewvc?rev=1914067=rev > Log: > Optimise handling LDAP authorization where LDAP was not used > previously for LDAP authentication. > >