Re: svn commit: r239436 - /httpd/httpd/trunk/support/htcacheclean.c

2005-08-23 Thread Justin Erenkrantz
--On August 23, 2005 5:03:03 PM + [EMAIL PROTECTED] wrote: Add APR_FOPEN_BINARY to the options passed to apr for opening the cache header files. Why? -- justin

Re: svn commit: r239436 - /httpd/httpd/trunk/support/htcacheclean.c

2005-08-23 Thread Colm MacCarthaigh
On Tue, Aug 23, 2005 at 12:05:13PM -0700, Justin Erenkrantz wrote: > --On August 23, 2005 5:03:03 PM + [EMAIL PROTECTED] wrote: > > >Add APR_FOPEN_BINARY to the options passed to apr for opening the > >cache header files. > > Why? Because mod_disk_cache uses; APR_CREATE | APR_WRI

Re: svn commit: r239436 - /httpd/httpd/trunk/support/htcacheclean.c

2005-08-23 Thread Justin Erenkrantz
--On August 23, 2005 8:18:44 PM +0100 Colm MacCarthaigh <[EMAIL PROTECTED]> wrote: Because mod_disk_cache uses; APR_CREATE | APR_WRITE | APR_BINARY | APR_EXCL when creating them, see inside store_headers at mod_disk_cache.c:892 It would have been helpful if you had noted that in the