Re: svn commit: r365376 - /httpd/httpd/branches/fcgi-proxy-dev/modules/proxy/mod_proxy_fcgi.c

2006-01-02 Thread Garrett Rooney
On 1/2/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Author: jim > Date: Mon Jan 2 08:52:58 2006 > New Revision: 365376 > > URL: http://svn.apache.org/viewcvs?rev=365376&view=rev > Log: > Avoid magic numbers. Since we are reading the header, let's > be explicit about it. Also removes the need

Re: svn commit: r365376 - /httpd/httpd/branches/fcgi-proxy-dev/modules/proxy/mod_proxy_fcgi.c

2006-01-03 Thread Jim Jagielski
Garrett Rooney wrote: > > On 1/2/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > Author: jim > > Date: Mon Jan 2 08:52:58 2006 > > New Revision: 365376 > > > > URL: http://svn.apache.org/viewcvs?rev=3D365376&view=3Drev > > Log: > > Avoid magic numbers. Since we are reading the header, let's

Re: svn commit: r365376 - /httpd/httpd/branches/fcgi-proxy-dev/modules/proxy/mod_proxy_fcgi.c

2006-01-03 Thread Garrett Rooney
On 1/3/06, Jim Jagielski <[EMAIL PROTECTED]> wrote: > Garrett Rooney wrote: > > > > On 1/2/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > > Author: jim > > > Date: Mon Jan 2 08:52:58 2006 > > > New Revision: 365376 > > > > > > URL: http://svn.apache.org/viewcvs?rev=3D365376&view=3Drev > > >

Re: svn commit: r365376 - /httpd/httpd/branches/fcgi-proxy-dev/modules/proxy/mod_proxy_fcgi.c

2006-01-03 Thread Jim Jagielski
Garrett Rooney wrote: > > The problem isn't just the number of bytes we read off the wire, it's > also that if the compiler has introduced padding between elements of > the struct when you recv directly into the struct the data is not > aligned with the proper members, so when you later access it