Re: svn commit: r407357 - in /httpd/httpd/trunk: CHANGES modules/cache/cache_storage.c

2006-05-22 Thread Joe Orton
On Sun, May 21, 2006 at 12:31:00PM +0200, Ruediger Pluem wrote: On 05/18/2006 10:50 AM, Joe Orton wrote: cache_storage.c: In function `cache_generate_key_default': cache_storage.c:383: warning: assignment discards qualifiers from pointer target type Fixed in r408154. Thanks. Great,

Re: svn commit: r407357 - in /httpd/httpd/trunk: CHANGES modules/cache/cache_storage.c

2006-05-22 Thread Ruediger Pluem
On 05/22/2006 04:49 PM, Joe Orton wrote: Great, thanks. In reply to your other questions: casts are bad :), and I don't think that performance is a good excuse for randomly manually inlining functions either (sometimes overall performance is improved by reducing executable size since

Re: svn commit: r407357 - in /httpd/httpd/trunk: CHANGES modules/cache/cache_storage.c

2006-05-21 Thread Ruediger Pluem
On 05/18/2006 10:50 AM, Joe Orton wrote: On Wed, May 17, 2006 at 07:16:43PM -, --- httpd/httpd/trunk/modules/cache/cache_storage.c (original) +++ httpd/httpd/trunk/modules/cache/cache_storage.c Wed May 17 12:16:43 2006 ... @@ -375,15 +380,18 @@ } } else { -

Re: svn commit: r407357 - in /httpd/httpd/trunk: CHANGES modules/cache/cache_storage.c

2006-05-18 Thread Joe Orton
On Wed, May 17, 2006 at 07:16:43PM -, [EMAIL PROTECTED] wrote: --- httpd/httpd/trunk/modules/cache/cache_storage.c (original) +++ httpd/httpd/trunk/modules/cache/cache_storage.c Wed May 17 12:16:43 2006 ... @@ -375,15 +380,18 @@ } } else { -scheme = http; +

Re: svn commit: r407357 - in /httpd/httpd/trunk: CHANGES modules/cache/cache_storage.c

2006-05-18 Thread Plüm , Rüdiger , VF EITO
-Ursprüngliche Nachricht- Von: Joe Orton ... @@ -375,15 +380,18 @@ } } else { -scheme = http; +scheme = ap_http_scheme(r); } cache_storage.c: In function `cache_generate_key_default': cache_storage.c:383: warning: assignment

Re: svn commit: r407357 - in /httpd/httpd/trunk: CHANGES modules/cache/cache_storage.c

2006-05-18 Thread Ruediger Pluem
On 05/18/2006 11:21 AM, Plüm wrote: -Ursprüngliche Nachricht- Von: Joe Orton ... @@ -375,15 +380,18 @@ } } else { -scheme = http; +scheme = ap_http_scheme(r); } cache_storage.c: In function `cache_generate_key_default': cache_storage.c:383: