Re: svn commit: r573831

2007-10-26 Thread Nick Kew
On Tue, 23 Oct 2007 00:22:56 +0200 André Malo [EMAIL PROTECTED] wrote: The main difference is this escaping of ' ' to '+'. The reason for this is that while ' ' gets encoded as %20 in paths, it gets encoded as '+' in query strings (afaik for historic reasons). Therefore, languages

svn commit: r573831

2007-10-22 Thread Günther Gsenger
Hi, sorry I can't reply directly to this thread http://mail-archives.apache.org/mod_mbox/httpd-dev/200709.mbox/[EMAIL PROTECTED] - i only (re)subscribed to this list today after I found the thread. +/* + * Escapes a uri in a similar way as php's urlencode does. + * Based on

Re: svn commit: r573831

2007-10-22 Thread Nick Kew
On Mon, 22 Oct 2007 21:03:25 +0200 Günther Gsenger [EMAIL PROTECTED] wrote: Hi, Hi, thanks for revisiting this! Ruediger Pluem: Does it make sense to duplicate code? Shouldn't this be placed in util.c? It most likely should. I placed it there because I thought the patch would get a

Re: svn commit: r573831

2007-10-22 Thread William A. Rowe, Jr.
Nick Kew wrote: Günther Gsenger [EMAIL PROTECTED] wrote: André Malo: This spreads another uri escaper copy around. Why can't we take ap_escape_uri? Without deep digging: what's the difference? Also I don't like the ' ' = '+' transition, which should not be applied forpaths. It's safer to

Re: svn commit: r573831

2007-10-22 Thread André Malo
* Nick Kew wrote: The main difference is this escaping of ' ' to '+'. The reason for this is that while ' ' gets encoded as %20 in paths, it gets encoded as '+' in query strings (afaik for historic reasons). Therefore, languages which interpret the query string (like PHP) might get

Re: svn commit: r573831 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_rewrite.xml modules/mappers/mod_rewrite.c

2007-09-11 Thread André Malo
* [EMAIL PROTECTED] wrote: Author: niq Date: Sat Sep 8 05:46:10 2007 New Revision: 573831 URL: http://svn.apache.org/viewvc?rev=573831view=rev Log: Add option to escape backreferences in RewriteRule. PR 34602 and PR 39746 Patch by Guenther Gsenger Modified:

Re: svn commit: r573831 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_rewrite.xml modules/mappers/mod_rewrite.c

2007-09-11 Thread Nick Kew
On Tue, 11 Sep 2007 15:11:35 +0200 André Malo [EMAIL PROTECTED] wrote: * [EMAIL PROTECTED] wrote: Author: niq Date: Sat Sep 8 05:46:10 2007 New Revision: 573831 URL: http://svn.apache.org/viewvc?rev=573831view=rev Log: Add option to escape backreferences in RewriteRule. PR

Re: svn commit: r573831 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_rewrite.xml modules/mappers/mod_rewrite.c

2007-09-11 Thread André Malo
* Nick Kew wrote: On Tue, 11 Sep 2007 15:11:35 +0200 André Malo [EMAIL PROTECTED] wrote: * [EMAIL PROTECTED] wrote: Author: niq Date: Sat Sep 8 05:46:10 2007 New Revision: 573831 URL: http://svn.apache.org/viewvc?rev=573831view=rev Log: Add option to escape

Re: svn commit: r573831 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_rewrite.xml modules/mappers/mod_rewrite.c

2007-09-11 Thread Nick Kew
On Tue, 11 Sep 2007 18:10:57 +0200 André Malo [EMAIL PROTECTED] wrote: A further improvement, round tuits permitting, would indeed be to look deeper, and eliminate any duplication. It should be done before considering backport, IMHO. Yep, guess so. I think I just put a proposal in STATUS

Re: svn commit: r573831 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_rewrite.xml modules/mappers/mod_rewrite.c

2007-09-09 Thread Ruediger Pluem
On 09/08/2007 02:46 PM, wrote: Author: niq Date: Sat Sep 8 05:46:10 2007 New Revision: 573831 URL: http://svn.apache.org/viewvc?rev=573831view=rev Log: Add option to escape backreferences in RewriteRule. PR 34602 and PR 39746 Patch by Guenther Gsenger Modified:

Re: svn commit: r573831 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_rewrite.xml modules/mappers/mod_rewrite.c

2007-09-09 Thread Nick Kew
On Sun, 09 Sep 2007 11:41:53 +0200 Ruediger Pluem [EMAIL PROTECTED] wrote: On 09/08/2007 02:46 PM, wrote: Author: niq Date: Sat Sep 8 05:46:10 2007 New Revision: 573831 URL: http://svn.apache.org/viewvc?rev=573831view=rev Log: Add option to escape backreferences in