Re: svn commit: r592951 - in /httpd/httpd/trunk: ./ docs/manual/mod/ include/ modules/filters/ modules/http/ server/

2007-12-01 Thread Nick Kew
On Wed, 07 Nov 2007 23:31:10 - [EMAIL PROTECTED] wrote: > Author: minfrin > Date: Wed Nov 7 15:31:03 2007 > New Revision: 592951 > > URL: http://svn.apache.org/viewvc?rev=592951&view=rev > Log: > core: Add the option to keep aside a request body up to a certain > size that would otherwise be

Re: svn commit: r592951 - in /httpd/httpd/trunk: ./ docs/manual/mod/ include/ modules/filters/ modules/http/ server/

2007-12-01 Thread Graham Leggett
Nick Kew wrote: You created a new kept_body input filter, which seems exactly right to me. But you're storing the kept body on the request_rec itself, which looks like extra complexity. Why not make the new filter into its own module, and keep the kept_body brigade on the filter's own config?

Re: svn commit: r592951 - in /httpd/httpd/trunk: ./ docs/manual/mod/ include/ modules/filters/ modules/http/ server/

2008-04-10 Thread Ruediger Pluem
On 02.12.2007 02:10, Graham Leggett wrote: Nick Kew wrote: You created a new kept_body input filter, which seems exactly right to me. But you're storing the kept body on the request_rec itself, which looks like extra complexity. Why not make the new filter into its own module, and keep the ke

Re: svn commit: r592951 - in /httpd/httpd/trunk: ./ docs/manual/mod/ include/ modules/filters/ modules/http/ server/

2008-09-19 Thread Paul Querna
Ruediger Pluem wrote: On 02.12.2007 02:10, Graham Leggett wrote: Nick Kew wrote: You created a new kept_body input filter, which seems exactly right to me. But you're storing the kept body on the request_rec itself, which looks like extra complexity. Why not make the new filter into its own

Re: svn commit: r592951 - in /httpd/httpd/trunk: ./ docs/manual/mod/ include/ modules/filters/ modules/http/ server/

2008-09-20 Thread Graham Leggett
Paul Querna wrote: +1, this revision r592951, and the derivate r647263 need to be rethought. IMO is that this doesn't belong in the reqeust_rec. I'm only realizing this went in 10 months after the first commit, and 5 months after it was rewritten in r647263, a sign of my inactivity in httpd