Re: svn commit: r606190 - in /httpd/httpd/trunk: CHANGES modules/ssl/ssl_engine_init.c modules/ssl/ssl_engine_kernel.c modules/ssl/ssl_toolkit_compat.h

2008-01-15 Thread Kaspar Brand
If I understand correctly, the current code is relying on ssl_hook_Access to perform a *second* handshake which will ensure that the named vhost's access control configuration is enforced, if necessary? No, that's probably due to a misunderstanding. In its current form, the patch will set

Re: svn commit: r606190 - in /httpd/httpd/trunk: CHANGES modules/ssl/ssl_engine_init.c modules/ssl/ssl_engine_kernel.c modules/ssl/ssl_toolkit_compat.h

2008-01-14 Thread Joe Orton
Thanks for the detailed response and sorry for the slow follow-up, Kaspar. I'll just deal with the main issue for the time being: On Wed, Jan 02, 2008 at 05:36:22PM +0100, Kaspar Brand wrote: Has a configuration with an SSLVerifyClient specified in the named vhost been tested? Yes, and

Re: svn commit: r606190 - in /httpd/httpd/trunk: CHANGES modules/ssl/ssl_engine_init.c modules/ssl/ssl_engine_kernel.c modules/ssl/ssl_toolkit_compat.h

2008-01-09 Thread Kaspar Brand
Kaspar Brand wrote: Has a configuration with an SSLVerifyClient specified in the named vhost been tested? Yes, and one specific configuration actually made me tweak the code in the servername callback further: [...] It turns out that this change was too radical, actually - it prevented

Re: svn commit: r606190 - in /httpd/httpd/trunk: CHANGES modules/ssl/ssl_engine_init.c modules/ssl/ssl_engine_kernel.c modules/ssl/ssl_toolkit_compat.h

2008-01-02 Thread Kaspar Brand
Joe, many thanks for your review and valuable comments, first off! As the person who contributed to the original SNI patch (authored by Peter Sylvester/EdelWeb), I'll try to address your questions to the best of my knowledge/ability. An updated version of the patch (based on Guenter's latest

Re: svn commit: r606190 - in /httpd/httpd/trunk: CHANGES modules/ssl/ssl_engine_init.c modules/ssl/ssl_engine_kernel.c modules/ssl/ssl_toolkit_compat.h

2007-12-28 Thread Joe Orton
On Fri, Dec 21, 2007 at 01:16:21PM -, [EMAIL PROTECTED] wrote: Author: fuankg Date: Fri Dec 21 05:16:21 2007 New Revision: 606190 URL: http://svn.apache.org/viewvc?rev=606190view=rev Log: Added server name indication (RFC 4366) support (PR 34607). Commits containing changes authored