Re: svn commit: r724745 - in /httpd/httpd/trunk: include/ap_socache.h modules/ssl/ssl_scache.c

2008-12-09 Thread Chris Darroch
Joe Orton wrote: * include/ap_socache.h: Use C++ safety wrappers, and rename ->delete to ->remove since the former is a C++ reserved word. Thanks again for the socache refactoring! I've been trying to keep these two modules up-to-date with both the socache stuff and Apache ZooKeeper (http

Re: svn commit: r724745 - in /httpd/httpd/trunk: include/ap_socache.h modules/ssl/ssl_scache.c

2008-12-12 Thread Joe Orton
On Tue, Dec 09, 2008 at 10:30:51AM -0800, Chris Darroch wrote: > Joe Orton wrote: > >> * include/ap_socache.h: Use C++ safety wrappers, and rename ->delete >> to ->remove since the former is a C++ reserved word. > > Thanks again for the socache refactoring! I've been trying to > keep these two

Re: svn commit: r724745 - in /httpd/httpd/trunk: include/ap_socache.h modules/ssl/ssl_scache.c

2008-12-12 Thread Chris Darroch
Joe Orton wrote: Both modules look very neat! Are you going to commit them? I might debate the naming of mod_shmap ;) Heh, thanks. I don't know, I hadn't really thought about committing them ... maybe the shmap one is more useful to other folks? - have all providers consistently return

Re: svn commit: r724745 - in /httpd/httpd/trunk: include/ap_socache.h modules/ssl/ssl_scache.c

2008-12-12 Thread Joe Orton
On Fri, Dec 12, 2008 at 11:15:49AM -0800, Chris Darroch wrote: > Joe Orton wrote: > >> Both modules look very neat! Are you going to commit them? I might >> debate the naming of mod_shmap ;) > > Heh, thanks. I don't know, I hadn't really thought about committing > them ... maybe the shmap on

Re: svn commit: r724745 - in /httpd/httpd/trunk: include/ap_socache.h modules/ssl/ssl_scache.c

2008-12-12 Thread Chris Darroch
Joe Orton wrote: mod_shmap would be useful at least in modules/test so I can write some perl-framework tests for mod_socache! OK, I'll think about doing that. The m4/dsp/NWGNU wizardry required makes me tired just thinking about it, though. :-) In the meantime, I think they compile again

Re: svn commit: r724745 - in /httpd/httpd/trunk: include/ap_socache.h modules/ssl/ssl_scache.c

2008-12-12 Thread Ruediger Pluem
On 12/12/2008 09:33 PM, Joe Orton wrote: > On Fri, Dec 12, 2008 at 11:15:49AM -0800, Chris Darroch wrote: >> Joe Orton wrote: >> >> One other thought ... does this change need an ap_mmn.h bump? > > Ah, I was waiting for Ruediger to ask ;) Personally I think it is I must have missed this dur