Re: svn commit: r818492 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache.c modules/cache/mod_cache.h

2009-09-24 Thread Ruediger Pluem
On 09/24/2009 04:25 PM, poir...@apache.org wrote: Author: poirier Date: Thu Sep 24 14:25:19 2009 New Revision: 818492 URL: http://svn.apache.org/viewvc?rev=818492view=rev Log: mod_cache: don't cache incomplete responses, per RFC 2616, 13.8. PR: 15866 Modified:

Re: svn commit: r818492 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache.c modules/cache/mod_cache.h

2009-09-24 Thread Dan Poirier
Ruediger Pluem rpl...@apache.org writes: On 09/24/2009 04:25 PM, poir...@apache.org wrote: + If there's some other cache provider that has to read the whole + cached body to fill in the brigade, though, that would make + this rather expensive. Exactly for this reason I

Re: svn commit: r818492 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache.c modules/cache/mod_cache.h

2009-09-24 Thread Ruediger Pluem
On 09/24/2009 10:18 PM, Dan Poirier wrote: Ruediger Pluem rpl...@apache.org writes: On 09/24/2009 04:25 PM, poir...@apache.org wrote: + If there's some other cache provider that has to read the whole + cached body to fill in the brigade, though, that would make + this

Re: svn commit: r818492 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_cache.c modules/cache/mod_cache.h

2009-09-24 Thread Graham Leggett
Dan Poirier wrote: What I'd been thinking about, but haven't implemented yet, was extending the cache provider API (in trunk only) so we can ask the cache provider for the size. Your idea of a wrapper function sounds good for 2.2 though, since it doesn't require an API change. How about