Re: svn commit: r883816 - in /httpd/httpd/trunk: include/util_mutex.h server/util_mutex.c

2009-11-24 Thread William A. Rowe Jr.
Nick Kew wrote: > > Regarding r883540 itself, I've just taken a look at it. > It seems to enforce the same mutex type on all modules that > use a mutex. Can't see an obvious reason not to do that, but > it might merit discussion on-list. For example, maybe someone > has a good reason to use diff

Re: svn commit: r883816 - in /httpd/httpd/trunk: include/util_mutex.h server/util_mutex.c

2009-11-24 Thread William A. Rowe Jr.
Jeff Trawick wrote: > > Many if not all other functions which handle directives and which are > not implemented in the same file as the directive declaration also > have the ap_ prefix, so I don't follow you on the "public" aspect. s/public/meant to be exported/ > But most of these other functio

Re: svn commit: r883816 - in /httpd/httpd/trunk: include/util_mutex.h server/util_mutex.c

2009-11-24 Thread Nick Kew
William A. Rowe Jr. wrote: traw...@apache.org wrote: --- httpd/httpd/trunk/include/util_mutex.h (original) +++ httpd/httpd/trunk/include/util_mutex.h Tue Nov 24 19:06:16 2009 @@ -99,9 +99,9 @@ const char **mutexfile); /* private function to process the

Re: svn commit: r883816 - in /httpd/httpd/trunk: include/util_mutex.h server/util_mutex.c

2009-11-24 Thread Jeff Trawick
On Tue, Nov 24, 2009 at 2:50 PM, William A. Rowe Jr. wrote: > traw...@apache.org wrote: >> --- httpd/httpd/trunk/include/util_mutex.h (original) >> +++ httpd/httpd/trunk/include/util_mutex.h Tue Nov 24 19:06:16 2009 >> @@ -99,9 +99,9 @@ >>                                          const char **mute

Re: svn commit: r883816 - in /httpd/httpd/trunk: include/util_mutex.h server/util_mutex.c

2009-11-24 Thread William A. Rowe Jr.
traw...@apache.org wrote: > --- httpd/httpd/trunk/include/util_mutex.h (original) > +++ httpd/httpd/trunk/include/util_mutex.h Tue Nov 24 19:06:16 2009 > @@ -99,9 +99,9 @@ > const char **mutexfile); > > /* private function to process the Mutex directive *