Re: svn commit: r942897 - in /httpd/httpd/trunk: CHANGES server/mpm/prefork/prefork.c

2010-05-21 Thread Jeff Trawick
On Wed, May 19, 2010 at 5:26 PM, Joe Orton jor...@redhat.com wrote: On Wed, May 12, 2010 at 03:30:29PM -0400, Jeff Trawick wrote: The multiple-calls-to-pool_clear solution is definitely safer. OK, so now I reviewed that too ;) The only difference between:   apr_pool_clear(ptrans);  

Re: svn commit: r942897 - in /httpd/httpd/trunk: CHANGES server/mpm/prefork/prefork.c

2010-05-19 Thread Joe Orton
On Wed, May 12, 2010 at 03:30:29PM -0400, Jeff Trawick wrote: The multiple-calls-to-pool_clear solution is definitely safer. OK, so now I reviewed that too ;) The only difference between: apr_pool_clear(ptrans); apr_pool_destroy(pchild); and simply: apr_pool_destroy(pchild); (given

Re: svn commit: r942897 - in /httpd/httpd/trunk: CHANGES server/mpm/prefork/prefork.c

2010-05-13 Thread Ruediger Pluem
On 10.05.2010 22:47, traw...@apache.org wrote: Author: trawick Date: Mon May 10 20:47:59 2010 New Revision: 942897 URL: http://svn.apache.org/viewvc?rev=942897view=rev Log: prefork MPM: Run cleanups for final request when process exits gracefully. PR: 43857 Submitted by: Tom Donovan,

Re: svn commit: r942897 - in /httpd/httpd/trunk: CHANGES server/mpm/prefork/prefork.c

2010-05-13 Thread Jeff Trawick
On Thu, May 13, 2010 at 4:43 AM, Ruediger Pluem rpl...@apache.org wrote: On 10.05.2010 22:47, traw...@apache.org wrote: Author: trawick Date: Mon May 10 20:47:59 2010 New Revision: 942897 URL: http://svn.apache.org/viewvc?rev=942897view=rev Log: prefork MPM: Run cleanups for final request

Re: svn commit: r942897 - in /httpd/httpd/trunk: CHANGES server/mpm/prefork/prefork.c

2010-05-13 Thread Rainer Jung
Rüdiger, Jeff rolled back this change in r943648 after a comment by Joe and committed an alternative approach in r943650. Regards, Rainer On 13.05.2010 10:43, Ruediger Pluem wrote: On 10.05.2010 22:47, traw...@apache.org wrote: Author: trawick Date: Mon May 10 20:47:59 2010 New Revision:

Re: svn commit: r942897 - in /httpd/httpd/trunk: CHANGES server/mpm/prefork/prefork.c

2010-05-12 Thread Joe Orton
On Mon, May 10, 2010 at 08:47:59PM -, Jeff Trawick wrote: --- httpd/httpd/trunk/server/mpm/prefork/prefork.c (original) +++ httpd/httpd/trunk/server/mpm/prefork/prefork.c Mon May 10 20:47:59 2010 @@ -549,12 +549,6 @@ static void child_main(int child_num_arg conn_rec *current_conn;

Re: svn commit: r942897 - in /httpd/httpd/trunk: CHANGES server/mpm/prefork/prefork.c

2010-05-12 Thread Jeff Trawick
On Wed, May 12, 2010 at 4:24 AM, Joe Orton jor...@redhat.com wrote: On Mon, May 10, 2010 at 08:47:59PM -, Jeff Trawick wrote: --- httpd/httpd/trunk/server/mpm/prefork/prefork.c (original) +++ httpd/httpd/trunk/server/mpm/prefork/prefork.c Mon May 10 20:47:59 2010 @@ -549,12 +549,6 @@