RE: Style

2014-10-07 Thread Plüm , Rüdiger , Vodafone Group
> -Original Message- > From: Christophe JAILLET [mailto:[email protected]] > Sent: Montag, 6. Oktober 2014 22:09 > To: [email protected] > Subject: Style > > > > So, do you think that such "clean up" worth the effort or that things > should be left as-is ? > Thanks for f

RE: svn commit: r1599531 - in /httpd/httpd/trunk: CHANGES include/ap_listen.h server/listen.c server/mpm/event/event.c server/mpm/prefork/prefork.c server/mpm/worker/worker.c server/mpm_unix.c

2014-10-07 Thread Lu, Yingqi
In the last version, I forgot to change _SC_NPROCESSORS_ONLN to _SC_NPROCESSORS_CONF for worker mpm. Please use this version to review. Sorry for the duplication. Thanks very much for your help! Yingqi -Original Message- From: Lu, Yingqi [mailto:[email protected]] Sent: Monday, Octo

Re: svn commit: r1599531 - in /httpd/httpd/trunk: CHANGES include/ap_listen.h server/listen.c server/mpm/event/event.c server/mpm/prefork/prefork.c server/mpm/worker/worker.c server/mpm_unix.c

2014-10-07 Thread Yann Ylavic
Hi Yingqi, thanks for your help. I finally commited a version (http://svn.apache.org/r1629909) where each child's bucket number is stored in the process scoreboard, so there is no need for each mpm to handle its own array. Can you please check that it works for you? Regards, Yann. On Tue, Oct

RE: svn commit: r1599531 - in /httpd/httpd/trunk: CHANGES include/ap_listen.h server/listen.c server/mpm/event/event.c server/mpm/prefork/prefork.c server/mpm/worker/worker.c server/mpm_unix.c

2014-10-07 Thread Lu, Yingqi
Thanks very much for your quick help! I will test it today and let you know. Thanks, Yingqi -Original Message- From: Yann Ylavic [mailto:[email protected]] Sent: Tuesday, October 07, 2014 8:21 AM To: httpd Subject: Re: svn commit: r1599531 - in /httpd/httpd/trunk: CHANGES include/ap

Re: svn commit: r1629909 - in /httpd/httpd/trunk: include/ap_mmn.h include/scoreboard.h server/mpm/event/event.c server/mpm/eventopt/eventopt.c server/mpm/prefork/prefork.c server/mpm/worker/worker.c

2014-10-07 Thread Ruediger Pluem
On 10/07/2014 05:16 PM, [email protected] wrote: > Author: ylavic > Date: Tue Oct 7 15:16:02 2014 > New Revision: 1629909 > > URL: http://svn.apache.org/r1629909 > Log: > core: Use process scoreboard to store each child's listener bucket, > and silently adjust the configured number of processes

Re: svn commit: r1629909 - in /httpd/httpd/trunk: include/ap_mmn.h include/scoreboard.h server/mpm/event/event.c server/mpm/eventopt/eventopt.c server/mpm/prefork/prefork.c server/mpm/worker/worker.c

2014-10-07 Thread Yann Ylavic
On Tue, Oct 7, 2014 at 8:59 PM, Ruediger Pluem wrote: > > On 10/07/2014 05:16 PM, [email protected] wrote: >> URL: >> http://svn.apache.org/viewvc/httpd/httpd/trunk/server/mpm/event/event.c?rev=1629909&r1=1629908&r2=1629909&view=diff >>

RE: svn commit: r1629909 - in /httpd/httpd/trunk: include/ap_mmn.h include/scoreboard.h server/mpm/event/event.c server/mpm/eventopt/eventopt.c server/mpm/prefork/prefork.c server/mpm/worker/worker.c

2014-10-07 Thread Lu, Yingqi
Hi Yann, I am still testing the fix. It is half way through. I already modified min_spare_threads to min_spare_threads/num_buckets for both worker and event MPM in my test bed, so I am testing the most recent version anyway (thought I would mention this together with the testing results). Rega

Re: svn commit: r1599531 - in /httpd/httpd/trunk: CHANGES include/ap_listen.h server/listen.c server/mpm/event/event.c server/mpm/prefork/prefork.c server/mpm/worker/worker.c server/mpm_unix.c

2014-10-07 Thread Yann Ylavic
There is a follow up in r1629990 (fix min_spare_threads lower bound and check wrt num_buckets). In fact there are 2 with a minor fix in r1629916, but I guess this latter can be ignored for testing. Regards, Yann. On Tue, Oct 7, 2014 at 5:28 PM, Lu, Yingqi wrote: > Thanks very much for your quic

Listeners buckets and duplication w/ and w/o SO_REUSEPORT on trunk

2014-10-07 Thread Yann Ylavic
Hi, some notes about the current implementation of this (trunk only). First, whether or not SO_REUSEPORT is available, we do duplicate the listeners. This, I think, is not the intention of Yingqi Lu's original proposal, and probably my fault since I asked for the patch to be splitted in two for a

RE: Listeners buckets and duplication w/ and w/o SO_REUSEPORT on trunk

2014-10-07 Thread Lu, Yingqi
Here is what I think. Currently (trunk version as well as my original patch), 1. Without SO_REUSEPORT or when available CPU number < 8, num_bucket = 1 anyway. It duplicates 1 listener and use that for this single bucket. If folks think we should not duplicate in this case, I can modify the code

RE: svn commit: r1629909 - in /httpd/httpd/trunk: include/ap_mmn.h include/scoreboard.h server/mpm/event/event.c server/mpm/eventopt/eventopt.c server/mpm/prefork/prefork.c server/mpm/worker/worker.c

2014-10-07 Thread Lu, Yingqi
I tested it and it works. Thanks, Yingqi -Original Message- From: Lu, Yingqi [mailto:[email protected]] Sent: Tuesday, October 07, 2014 3:13 PM To: [email protected] Subject: RE: svn commit: r1629909 - in /httpd/httpd/trunk: include/ap_mmn.h include/scoreboard.h server/mpm/event/ev

Re: Listeners buckets and duplication w/ and w/o SO_REUSEPORT on trunk

2014-10-07 Thread Yann Ylavic
On Wed, Oct 8, 2014 at 1:50 AM, Lu, Yingqi wrote: > Here is what I think. Currently (trunk version as well as my original patch), > > 1. Without SO_REUSEPORT or when available CPU number < 8, num_bucket = 1 > anyway. It duplicates 1 listener and use that for this single bucket. If > folks think

RE: Listeners buckets and duplication w/ and w/o SO_REUSEPORT on trunk

2014-10-07 Thread Lu, Yingqi
Regarding to your comments #2, we tested on a 16 thread system and it does not bring any performance value. That is the reason I calculate this way. Thanks for the comments below. I will try to send out a fix soon. Thanks, Yingqi -Original Message- From: Yann Ylavic [mailto:ylavic@g

Re: Listeners buckets and duplication w/ and w/o SO_REUSEPORT on trunk

2014-10-07 Thread Yann Ylavic
On Wed, Oct 8, 2014 at 2:03 AM, Yann Ylavic wrote: > On Wed, Oct 8, 2014 at 1:50 AM, Lu, Yingqi wrote: >> 3. Yes, I did use some extern variables. I can change the name of them to >> better coordinate with the variable naming conversion. We should do >> something with ap_prefixed? Is there anyt

Re: Listeners buckets and duplication w/ and w/o SO_REUSEPORT on trunk

2014-10-07 Thread Yann Ylavic
On Wed, Oct 8, 2014 at 2:26 AM, Yann Ylavic wrote: > On Wed, Oct 8, 2014 at 2:03 AM, Yann Ylavic wrote: >> On Wed, Oct 8, 2014 at 1:50 AM, Lu, Yingqi wrote: >>> 3. Yes, I did use some extern variables. I can change the name of them to >>> better coordinate with the variable naming conversion. W