Re: httpd-2.3.9-alpha test tarballs

2010-11-26 Thread Gregg L. Smith 

Hi Stefan,

Yes, that did it. Builds vc6/9 and answers http/s.
Thank you for your attention to this.

While you commit win3.diff, it seems mod_disk_cache was changed to 
mod_cache_disk and I remember seeing mention of it. The patch attached 
is some clean ups needed for it.



Cheers

Gregg


Stefan Fritsch wrote:

Hi,

On Thursday 25 November 2010, Gregg L. Smith wrote:

Much better, results seem to be the same as Guenter's;

\server\util_expr_eval.c(350) : error C2440: ':' : cannot convert
from 'int (__stdcall *)(ap_expr_lookup_parms *)' to
'ap_expr_lookup_fn (__cdecl *)'

\server\util_expr_eval.c(350) : error C2440: '=' : cannot convert
from 'ap_expr_lookup_fn (__stdcall *)' to 'ap_expr_lookup_fn
(__cdecl *)'


ok, patch number three is attached. I have commited the other changes 
to trunk.


Cheers,
Stefan


Index: makefile.win

--- makefile.win2010-11-04 15:58:48.0 -0700
+++ makefile.win2010-11-25 23:01:31.049875000 -0800
@@ -377,8 +377,8 @@
cd ..\..\..
cd modules\cache
 $(MAKE) $(MAKEOPT) -f mod_cache.mak   CFG=mod_cache - Win32 
$(LONG) RECURSE=0 $(CTARGET)
+$(MAKE) $(MAKEOPT) -f mod_cache_disk.mak  CFG=mod_cache_disk - Win32 
$(LONG) RECURSE=0 $(CTARGET)
 $(MAKE) $(MAKEOPT) -f mod_file_cache.mak  CFG=mod_file_cache - Win32 
$(LONG) RECURSE=0 $(CTARGET)
-$(MAKE) $(MAKEOPT) -f mod_disk_cache.mak  CFG=mod_disk_cache - Win32 
$(LONG) RECURSE=0 $(CTARGET)
 $(MAKE) $(MAKEOPT) -f mod_socache_dbm.mak CFG=mod_socache_dbm - Win32 
$(LONG) RECURSE=0 $(CTARGET)
 #   $(MAKE) $(MAKEOPT) -f mod_socache_dc.mak  CFG=mod_socache_dc - Win32 
$(LONG) RECURSE=0 $(CTARGET)
 $(MAKE) $(MAKEOPT) -f mod_socache_memcache.mak 
CFG=mod_socache_memcache - Win32 $(LONG) RECURSE=0 $(CTARGET)
@@ -637,8 +637,8 @@
copy modules\aaa\$(LONG)\mod_authz_user.$(src_so)   $(inst_so) .y
copy modules\arch\win32\$(LONG)\mod_isapi.$(src_so) $(inst_so) .y
copy modules\cache\$(LONG)\mod_cache.$(src_so)  $(inst_so) .y
+   copy modules\cache\$(LONG)\mod_cache_disk.$(src_so) $(inst_so) .y
copy modules\cache\$(LONG)\mod_file_cache.$(src_so) $(inst_so) .y
-   copy modules\cache\$(LONG)\mod_disk_cache.$(src_so) $(inst_so) .y
copy modules\cache\$(LONG)\mod_socache_dbm.$(src_so)$(inst_so) .y
 #  copy modules\cache\$(LONG)\mod_socache_dc.$(src_so) $(inst_so) .y
copy modules\cache\$(LONG)\mod_socache_memcache.$(src_so) $(inst_so) 
.y
Index: build/installwinconf.awk

--- build/installwinconf.awk2010-11-25 23:04:46.56550 -0800
+++ build/installwinconf.awk2010-11-26 00:12:02.487375000 -0800
@@ -112,6 +112,7 @@
  print LoadModule authz_user_module modules/mod_authz_user.so  
dstfl;
  print LoadModule autoindex_module modules/mod_autoindex.so  dstfl;
  print #LoadModule cache_module modules/mod_cache.so  dstfl;
+ print #LoadModule cache_disk_module modules/mod_cache_disk.so  
dstfl;
  print #LoadModule cern_meta_module modules/mod_cern_meta.so  dstfl;
  print LoadModule cgi_module modules/mod_cgi.so  dstfl;
  print #LoadModule charset_lite_module modules/mod_charset_lite.so  
dstfl;
@@ -121,7 +122,6 @@
  print #LoadModule dbd_module modules/mod_dbd.so  dstfl;
  print #LoadModule deflate_module modules/mod_deflate.so  dstfl;
  print LoadModule dir_module modules/mod_dir.so  dstfl;
- print #LoadModule disk_cache_module modules/mod_disk_cache.so  
dstfl;
  print #LoadModule dumpio_module modules/mod_dumpio.so  dstfl;
  print LoadModule env_module modules/mod_env.so  dstfl;
  print #LoadModule expires_module modules/mod_expires.so  dstfl;
Index: os/win32/baseaddr.ref

--- os/win32/baseaddr.ref   2010-11-25 23:58:41.25300 -0800
+++ os/win32/baseaddr.ref   2010-11-25 23:58:57.393625000 -0800
@@ -45,7 +45,7 @@
 mod_setenvif.so 0x6FC00x0001
 mod_userdir.so  0x6FBF0x0001
 mod_cache.so0x6FBE0x0001
-mod_disk_cache.so   0x6FBD0x0001
+mod_cache_disk.so   0x6FBD0x0001
 mod_buffer.so   0x6FBC0x0001
 mod_deflate.so  0x6FBA0x0002
 mod_ext_filter.so   0x6FB90x0001

Re: httpd-2.3.9-alpha test tarballs

2010-11-26 Thread Rainer Jung 

On 26.11.2010 09:30, Gregg L. Smith wrote:

While you commit win3.diff, it seems mod_disk_cache was changed to
mod_cache_disk and I remember seeing mention of it. The patch attached
is some clean ups needed for it.


I committed the mod_cache_disk Windows build fixes in r1039295.
Thanks!

Rainer

Re: httpd-2.3.9-alpha test tarballs

2010-11-26 Thread Guenter Knauf 

Hi Stefan,
do you think these warnings can be fixed too?
Or is this related to the flex version used?

### mwccnlm Compiler:
#File: server\util_expr_scan.c
# 
#2340:  {
# Warning:  ^
#   function has no prototype
### mwccnlm Compiler:
#2416:  {
# Warning:  ^
#   function has no prototype

thanks, Gün.

segfault with POST

2010-11-26 Thread Oden Eriksson 
Hello.

We're currenty experiencing a strange segfault in Mandriva Cooker (the 
development branch) with the latest apache-2.2.17, gcc-4.5.1 and all that.

Compiling apache using -DDEBUG=1 -DAPR_BUCKET_DEBUG=1 -DAPR_RING_DEBUG=1 or 
without -fomit-frame-pointer makes the segfault go away. This seems to 
happen on 32bit cooker only.

More info here:

https://qa.mandriva.com/show_bug.cgi?id=61384

A possible related issue in WebDAV:

https://qa.mandriva.com/show_bug.cgi?id=61655

Cheers.
-- 
Regards // Oden Eriksson
Security team manager - Mandriva
CEO NUX AB

Re: httpd-2.3.9-alpha test tarballs

2010-11-26 Thread Stefan Fritsch 
On Friday 26 November 2010, Guenter Knauf wrote:
 Hi Stefan,
 do you think these warnings can be fixed too?
 Or is this related to the flex version used?
 
 ### mwccnlm Compiler:
 #File: server\util_expr_scan.c
 # 
 #2340:  {
 # Warning:  ^
 #   function has no prototype
 ### mwccnlm Compiler:
 #2416:  {
 # Warning:  ^
 #   function has no prototype
 
 thanks, Gün.

Yes, these are related to a flex bug. I have added a hack to the 
Makefile that removes the (unused) functions.

Re: httpd-2.3.9-alpha test tarballs

2010-11-26 Thread Stefan Fritsch 
On Friday 26 November 2010, Rainer Jung wrote:
 On 26.11.2010 09:30, Gregg L. Smith wrote:
  While you commit win3.diff, it seems mod_disk_cache was changed
  to mod_cache_disk and I remember seeing mention of it. The patch
  attached is some clean ups needed for it.
 
 I committed the mod_cache_disk Windows build fixes in r1039295.
 Thanks!

BTW, does anyone have an idea how best to fix the test framework (in 
particular t/modules/cache.t) to depend on mod_cache_disk OR 
mod_disk_cache?

Re: httpd-2.3.9-alpha test tarballs

2010-11-26 Thread Guenter Knauf 

Stefan,
Am 26.11.2010 21:15, schrieb Stefan Fritsch:

Yes, these are related to a flex bug. I have added a hack to the
Makefile that removes the (unused) functions.

thanks.

Not that you think now I ask you for fixing each and every silly 
warning, but since I'm not familar with that flex stuff I just mention 
this one FYI:

util_expr_parse.c(1877): Warning! W124: Comparison result always 1

Gün.