Re: T of 2.4.17 this week

2015-10-07 Thread Steffen
Do we need in LICENSE.txt the license of nghttp2 (MIT) ? Also missing there libxml2. On Wednesday 07/10/2015 at 15:46, Jim Jagielski wrote: So the plan is to T sometime tomorrow, likely later on in the afternoon, eastern time.

Re: svn commit: r1706275 - /httpd/httpd/trunk/modules/ssl/ssl_engine_io.c

2015-10-07 Thread Graham Leggett
On 07 Oct 2015, at 7:46 PM, Plüm, Rüdiger, Vodafone Group wrote: > I guess we are talking of different things. During the initial handshake > (client or server) we never hand back > control to the event part of the MPM. We never use ssl_filter_write and >

Re: Supporting "SSL:" in the expression parser via mod_ssl

2015-10-07 Thread Rainer Jung
Option 3) tested and committed to trunk in r1707152, tested and proposed to backport for 2.4 now. Thanks for the feedback! Regards, Rainer Am 06.10.2015 um 12:12 schrieb Plüm, Rüdiger, Vodafone Group: +1 Regards Rüdiger -Original Message- From: Yann Ylavic

Re: svn commit: r1706275 - /httpd/httpd/trunk/modules/ssl/ssl_engine_io.c

2015-10-07 Thread Joe Orton
On Wed, Oct 07, 2015 at 01:35:38AM +0200, Yann Ylavic wrote: > For the server case, openssl will use its own buffering mechanism > during the handshake "so that the output is sent in a way that TCP > likes", according to the comment in the code, so we shouldn't be > flushing small chunks. > Yet

Re: svn commit: r1707159 - /httpd/httpd/trunk/server/eor_bucket.c

2015-10-07 Thread Yann Ylavic
On Wed, Oct 7, 2015 at 9:10 PM, Yann Ylavic wrote: > On Wed, Oct 7, 2015 at 8:45 PM, Ruediger Pluem wrote: >> >> >> On 10/07/2015 12:23 AM, yla...@apache.org wrote: >>> >>> static void eor_bucket_destroy(void *data) >>> { >>> -request_rec *r =

Re: svn commit: r1707163 - /httpd/httpd/trunk/server/util_filter.c

2015-10-07 Thread Graham Leggett
On 07 Oct 2015, at 1:54 AM, Yann Ylavic wrote: > I don't understand this, why using ap_save_brigade() for both cases > (i.e. setting aside or reading the other types of buckets) would lead > to synchronous behaviour? > It is when r->pool gets destroyed? > If so, how is it

Re: svn commit: r1707241 - /httpd/httpd/branches/2.4.x/STATUS

2015-10-07 Thread Rainer Jung
Am 07.10.2015 um 13:03 schrieb yla...@apache.org: Author: ylavic Date: Wed Oct 7 11:03:22 2015 New Revision: 1707241 URL: http://svn.apache.org/viewvc?rev=1707241=rev Log: Fix commit revision of Rainer's proposal. Thanks, I wonder where I got the wrong one from. I usually do copy and paste

Re: svn commit: r1706275 - /httpd/httpd/trunk/modules/ssl/ssl_engine_io.c

2015-10-07 Thread Graham Leggett
On 07 Oct 2015, at 10:04 AM, Joe Orton wrote: > That's really interesting. That extra buffering BIO makes sense if > OpenSSL is writing to the socket descriptor directly, as with pre-2.x > mod_ssl, but doesn't really make sense with 2.x mod_ssl, since the core > output

Re: Serf and mod_lua and libmill (Was: Re: [Patch] Async write completion for the full connection filter stack)

2015-10-07 Thread Graham Leggett
On 05 Oct 2015, at 5:13 PM, Eric Covener wrote: > It seems like > extending that to handlers (and implicitly, request filters) is more > the "can't be done" part. Having had a chance to look at the handlers in more detail, I suspect the problem is that async support wasn’t

Re: about those async filters

2015-10-07 Thread Graham Leggett
On 07 Oct 2015, at 3:43 PM, Stefan Eissing wrote: > Having just had time to look at which test cases fail: I see that static > resources via HTTP/2 seem to work fine, however my tests with a proxy and or > rewrite in between fail with high likelihood. > > Any

about those async filters

2015-10-07 Thread Stefan Eissing
Having just had time to look at which test cases fail: I see that static resources via HTTP/2 seem to work fine, however my tests with a proxy and or rewrite in between fail with high likelihood. Any hint at what exactly I might have to look for, any hint about what actually has changed,

Re: svn commit: r1707161 - in /httpd/httpd/trunk: docs/manual/mod/core.xml include/ap_mmn.h include/http_core.h include/httpd.h server/core.c server/request.c server/util_filter.c

2015-10-07 Thread Jeff Trawick
On Tue, Oct 6, 2015 at 6:33 PM, wrote: > Author: minfrin > Date: Tue Oct 6 22:33:03 2015 > New Revision: 1707161 > > URL: http://svn.apache.org/viewvc?rev=1707161=rev > Log: > Add the AsyncFilter directive that allows the asynchronous filter > functionality to be switched

Re: T of 2.4.17 this week

2015-10-07 Thread Jim Jagielski
So the plan is to T sometime tomorrow, likely later on in the afternoon, eastern time.

Re: about those async filters

2015-10-07 Thread Yann Ylavic
Hi Stefan, On Wed, Oct 7, 2015 at 3:43 PM, Stefan Eissing wrote: > Having just had time to look at which test cases fail: I see that static > resources via HTTP/2 seem to work fine, however my tests with a proxy and or > rewrite in between fail with high

Re: about those async filters

2015-10-07 Thread Stefan Eissing
> Am 07.10.2015 um 16:09 schrieb Graham Leggett : > > On 07 Oct 2015, at 3:43 PM, Stefan Eissing > wrote: > >> Having just had time to look at which test cases fail: I see that static >> resources via HTTP/2 seem to work fine, however my tests

AW: svn commit: r1706275 - /httpd/httpd/trunk/modules/ssl/ssl_engine_io.c

2015-10-07 Thread Plüm , Rüdiger , Vodafone Group
> -Ursprüngliche Nachricht- > Von: Graham Leggett [mailto:minf...@sharp.fm] > Gesendet: Mittwoch, 7. Oktober 2015 17:59 > An: dev@httpd.apache.org > Betreff: Re: svn commit: r1706275 - > /httpd/httpd/trunk/modules/ssl/ssl_engine_io.c > > On 07 Oct 2015, at 5:53 PM, Jim Jagielski

Re: svn commit: r1706275 - /httpd/httpd/trunk/modules/ssl/ssl_engine_io.c

2015-10-07 Thread Graham Leggett
On 07 Oct 2015, at 5:53 PM, Jim Jagielski wrote: >> As I understand we’re using openssl in non blocking mode, which means that >> openssl will ask us permission before attempting any read or write. >> >> The core will then in turn either read or write as requested by openssl

Re: about those async filters

2015-10-07 Thread Stefan Eissing
> Am 07.10.2015 um 17:55 schrieb Graham Leggett : > > On 07 Oct 2015, at 4:30 PM, Stefan Eissing > wrote: >> [...] >> Due to the non-multithreadability of apr_buckets, no buckets are ever moved >> across threads. non-meta buckets are read, meta

Re: svn commit: r1706275 - /httpd/httpd/trunk/modules/ssl/ssl_engine_io.c

2015-10-07 Thread Jim Jagielski
> On Oct 7, 2015, at 11:59 AM, Graham Leggett wrote: > > On 07 Oct 2015, at 5:53 PM, Jim Jagielski wrote: > >>> As I understand we’re using openssl in non blocking mode, which means that >>> openssl will ask us permission before attempting any read or

Re: svn commit: r1706275 - /httpd/httpd/trunk/modules/ssl/ssl_engine_io.c

2015-10-07 Thread Jim Jagielski
> On Oct 7, 2015, at 5:17 AM, Graham Leggett wrote: > > On 07 Oct 2015, at 10:04 AM, Joe Orton wrote: > >> That's really interesting. That extra buffering BIO makes sense if >> OpenSSL is writing to the socket descriptor directly, as with pre-2.x >>

Re: about those async filters

2015-10-07 Thread Graham Leggett
On 07 Oct 2015, at 4:30 PM, Stefan Eissing wrote: >> Can you describe how cleanups occur in the http2 world? > > In http2 land, the request happen on "pseudo" connections, connections > properly created by ap_run_create_connection(), but with own filters of type

Re: svn commit: r1706275 - /httpd/httpd/trunk/modules/ssl/ssl_engine_io.c

2015-10-07 Thread Yann Ylavic
On Wed, Oct 7, 2015 at 5:59 PM, Graham Leggett wrote: > On 07 Oct 2015, at 5:53 PM, Jim Jagielski wrote: > >>> As I understand we’re using openssl in non blocking mode, which means that >>> openssl will ask us permission before attempting any read or write.

Re: svn commit: r1707159 - /httpd/httpd/trunk/server/eor_bucket.c

2015-10-07 Thread Yann Ylavic
On Wed, Oct 7, 2015 at 8:45 PM, Ruediger Pluem wrote: > > > On 10/07/2015 12:23 AM, yla...@apache.org wrote: >> >> static void eor_bucket_destroy(void *data) >> { >> -request_rec *r = (request_rec *)data; >> +apr_bucket *h = data; > > IMHO this should be > >

Re: svn commit: r1707159 - /httpd/httpd/trunk/server/eor_bucket.c

2015-10-07 Thread Ruediger Pluem
On 10/07/2015 12:23 AM, yla...@apache.org wrote: > Author: ylavic > Date: Tue Oct 6 22:23:24 2015 > New Revision: 1707159 > > URL: http://svn.apache.org/viewvc?rev=1707159=rev > Log: > eor_bucket: follow up to r1707084: use an inner shared bucket. > > Modified: >

Re: about those async filters

2015-10-07 Thread Graham Leggett
On 07 Oct 2015, at 6:23 PM, Stefan Eissing wrote: >> Can you explain "non-multithreadability of apr_buckets” in more detail? I >> take it this is the problem with passing a bucket from one allocator to >> another? >> >> If so then the copy makes more sense. > >