Re: svn commit: r726113 - /httpd/httpd/trunk/server/mpm/worker/fdqueue.c

2008-12-22 Thread Basant Kumar kukreja
Yes, unless until we clearly understand that volatile is not useful here, we should keep it. Regards, Basant. On Fri, Dec 12, 2008 at 02:57:03PM -0800, Chris Darroch wrote: Ruediger Pluem wrote: Not quite sure if this is really correct because apr_atomic_casptr wants to have a (volatile

Re: svn commit: r691418 [1/2] - in /httpd/httpd/trunk: ./ docs/manual/mod/ modules/filters/

2008-12-22 Thread Basant Kumar kukreja
* Transient bucket seems to be working fine in mod_sed. * Added error handling code so that if ap_pass_brigade fails during request processing, error is returned to sed_response_filter / sed_request_filter. Testing : * Compiled with 2.2 branch and make sure there is no regression (against

Re: svn commit: r691418 [2/2] - in/httpd/httpd/trunk:./docs/manual/mod/ modules/filters/

2008-09-11 Thread Basant Kumar kukreja
On Thu, Sep 11, 2008 at 10:36:18PM +0200, Ruediger Pluem wrote: On 09/10/2008 11:40 PM, Basant Kumar kukreja wrote: Patch is attached. I have tested the patch. It now prints \10 and \11 for character values 0x8 and 0x9. Thanks for the patch. Committed as r694431 (http://svn.apache.org

Re: svn commit: r691418 [2/2] - in/httpd/httpd/trunk:./docs/manual/mod/ modules/filters/

2008-09-10 Thread Basant Kumar kukreja
Patch is attached. I have tested the patch. It now prints \10 and \11 for character values 0x8 and 0x9. Regards, Basant. On Wed, Sep 10, 2008 at 04:00:42PM +0200, Plüm, Rüdiger, VF-Group wrote: -Ursprüngliche Nachricht- Von: [EMAIL PROTECTED] Gesendet: Mittwoch, 10. September

Re: svn commit: r691418 [1/2] - in /httpd/httpd/trunk: ./ docs/manual/mod/ modules/filters/

2008-09-05 Thread Basant Kumar kukreja
+ OutputSed s/sunday/SUN/g br / I guess it should be InputSed here. Patch for the documentation fix is attached. Regards, Basant. $ svn diff mod_sed.xml Index: mod_sed.xml === --- mod_sed.xml (revision 692275) +++

Re: svn commit: r691418 [1/2] - in /httpd/httpd/trunk: ./ docs/manual/mod/ modules/filters/

2008-09-05 Thread Basant Kumar kukreja
Just a note : sed original code also have ATT copyright. http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/ucbcmd/sed/sed1.c http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/ucbcmd/sed/sed0.c http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/ucbcmd/sed/sed.h

Re: Dropping mod_sed into /trunk/ ?

2008-08-21 Thread Basant Kumar kukreja
Thanks Nick for your initiative to make it part of Apache httpd. I am glad to contribute to the Apache Software Foundation. On Thu, Aug 21, 2008 at 02:04:14PM +0100, Nick Kew wrote: On 21 Aug 2008, at 13:28, Jim Jagielski wrote: On Aug 20, 2008, at 6:53 PM, Nick Kew wrote: A little while