hung apache during shutdown, was: one word syncronize once more

2007-07-26 Thread Darryl L. Miles
From another thread Re: one word syncronize once more, new thread created as I also don't believe the issues are related. Greg Ames wrote: if you have a hung server, I would do some more diagnosis and not get sidetracked by MRPC. have you looked for unusual messages in the error log

Re: one word syncronize once more

2007-07-26 Thread Greg Ames
word syncronize once more Greg Ames wrote: please see rev. 558039. requests_this_child does not need to be 100% accurate. the cure below is worse than the disease. Greg -requests_this_child--; /* FIXME: should be synchronized - aaron */ +apr_atomic_dec32

Re: one word syncronize once more

2007-07-20 Thread Greg Ames
please see rev. 558039. requests_this_child does not need to be 100% accurate. the cure below is worse than the disease. Greg - Original Message From: Dmytro Fedonin [EMAIL PROTECTED] To: dev@httpd.apache.org Sent: Thursday, June 14, 2007 11:49:42 AM Subject: one word syncronize once

Re: one word syncronize once more

2007-07-20 Thread Darryl Miles
Greg Ames wrote: please see rev. 558039. requests_this_child does not need to be 100% accurate. the cure below is worse than the disease. Greg -requests_this_child--; /* FIXME: should be synchronized - aaron */ +apr_atomic_dec32(requests_this_child); /* much slower than

Re: one word syncronize

2007-06-20 Thread Darryl Miles
sebb wrote: On 14/06/07, Dmytro Fedonin [EMAIL PROTECTED] wrote: Looking through 'server/mpm/worker/worker.c' I have found such a combination of TODO/FIXME comments: 1) /* TODO: requests_this_child should be synchronized - aaron */ if (requests_this_child = 0) { 2) requests_this_child--; /*

one word syncronize

2007-06-14 Thread Dmytro Fedonin
Hi all, Looking through 'server/mpm/worker/worker.c' I have found such a combination of TODO/FIXME comments: 1) /* TODO: requests_this_child should be synchronized - aaron */ if (requests_this_child = 0) { 2) requests_this_child--; /* FIXME: should be synchronized - aaron */ And I can not see

one word syncronize once more

2007-06-14 Thread Dmytro Fedonin
Hi all, I've got some response which shows that I was not clear enough in my previous post. Fullproof solution would be: Index: server/mpm/worker/worker.c === --- server/mpm/worker/worker.c (revision 545597) +++

Re: one word syncronize

2007-06-14 Thread sebb
On 14/06/07, Dmytro Fedonin [EMAIL PROTECTED] wrote: Hi all, Looking through 'server/mpm/worker/worker.c' I have found such a combination of TODO/FIXME comments: 1) /* TODO: requests_this_child should be synchronized - aaron */ if (requests_this_child = 0) { 2) requests_this_child--; /* FIXME: