[EMAIL PROTECTED] wrote:
--- httpd/httpd/trunk/modules/cache/mod_disk_cache.c (original)
+++ httpd/httpd/trunk/modules/cache/mod_disk_cache.c Tue Mar 28 22:53:51 2006
@@ -984,7 +984,15 @@
{
const char *str;
apr_size_t length, written;
-apr_bucket_read(e,
-Ursprüngliche Nachricht-
Von: Jim Jagielski
+file_cache_errorcleanup(dobj, r);
+return APR_EGENERAL;
+}
Why don't we return rv ?
Because we also return APR_EGENERAL in the cases below. I think the behaviour
should be consistent. So if we
=?iso-8859-1?Q?Pl=FCm=2C_R=FCdiger=2C_VIS?= wrote:
-Urspr=FCngliche Nachricht-
Von: Jim Jagielski=20
=20
+file_cache_errorcleanup(dobj, r);
+return APR_EGENERAL;
+}
=20
Why don't we return rv ?
Because we also return APR_EGENERAL
-Ursprüngliche Nachricht-
Von: Jim Jagielski
That seem to be the case when we have a general error. In other
places where we have a valid 'rv', we tend to return that.
Look at file_cache_recall_mydata() for example...
In the above, I think the return status may be useful,
