* Transient bucket seems to be working fine in mod_sed.
* Added error handling code so that if ap_pass_brigade fails during
request processing, error is returned to sed_response_filter /
sed_request_filter.
Testing :
* Compiled with 2.2 branch and make sure there is no regression (against
Hi,
Attached is the *rough* patch which uses transient buckets in mod_sed output
filter.
Testing :
I created a 30MB and 300MB text files and ran OutputSed commands on the file.
* Before the patch, process size (worker mpm with 1 thread) increased up to
300M
for single request. After the
Nick Kew wrote:
On Thu, 04 Sep 2008 21:47:26 -0500
William A. Rowe, Jr. [EMAIL PROTECTED] wrote:
Basant Kukreja wrote:
Based on your suggestion, I will check what are the other
improvements from mod_substitute can be brought into mod_sed.
Note that mod_substitute's brigade handling is
+ OutputSed s/sunday/SUN/g br /
I guess it should be InputSed here.
Patch for the documentation fix is attached.
Regards,
Basant.
$ svn diff mod_sed.xml
Index: mod_sed.xml
===
--- mod_sed.xml (revision 692275)
+++
Just a note : sed original code also have ATT copyright.
http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/ucbcmd/sed/sed1.c
http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/ucbcmd/sed/sed0.c
http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/ucbcmd/sed/sed.h
On Sep 5, 2008, at 4:04 PM, Basant Kumar kukreja wrote:
Just a note : sed original code also have ATT copyright.
http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/
ucbcmd/sed/sed1.c
http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/
ucbcmd/sed/sed0.c
On 09/03/2008 01:01 AM, [EMAIL PROTECTED] wrote:
Author: niq
Date: Tue Sep 2 16:01:47 2008
New Revision: 691418
URL: http://svn.apache.org/viewvc?rev=691418view=rev
Log:
Commit mod_sed: enable filtering of HTTP Requests and Responses through sed
Added:
Apologies if this was already discussed and resolved, but I
see quite a number of:
* Copyright (c) 1984 ATT
*All Rights Reserved
in various files... Can we track the IP of those parts to
ensure that we (and Sun) have the required license to use
them??
On Thu, 4 Sep 2008 10:12:39 -0400
Jim Jagielski [EMAIL PROTECTED] wrote:
On Sep 4, 2008, at 6:38 AM, Ruediger Pluem wrote:
More comments possibly later.
For the most part, it looks like many of the optimizations
in mod_substitute, esp regarding efficient use of buckets,
is lacking
