Re: svn commit: r721952 - in /httpd/httpd/trunk: ./ modules/ modules/cluster/

2008-12-06 Thread Takashi Sato
On Mon, 01 Dec 2008 02:55:15 - [EMAIL PROTECTED] wrote: Author: pquerna Date: Sun Nov 30 18:55:14 2008 New Revision: 721952 URL: http://svn.apache.org/viewvc?rev=721952view=rev Log: Add two new modules, originally written at Joost, to handle load balancing across multiple apache

Re: svn commit: r721952 - in /httpd/httpd/trunk: ./ modules/ modules/cluster/

2008-12-06 Thread Paul Querna
Takashi Sato wrote: On Mon, 01 Dec 2008 02:55:15 - [EMAIL PROTECTED] wrote: Author: pquerna Date: Sun Nov 30 18:55:14 2008 New Revision: 721952 + +static void *hb_worker(apr_thread_t *thd, void *data) Don't this need to be APR_THREAD_FUNC? Fixed in r724090. +{ +hb_ctx_t

Re: svn commit: r721952 - in /httpd/httpd/trunk: ./ modules/ modules/cluster/

2008-12-05 Thread Paul Querna
Ruediger Pluem wrote: +typedef struct hb_ctx_t +{ +int active; +apr_sockaddr_t *mcast_addr; +int server_limit; +int thread_limit; +int status; +int keep_running; Shouldn't this be volatile? Changed, r723660. +if (res == SERVER_READY

Re: svn commit: r721952 - in /httpd/httpd/trunk: ./ modules/ modules/cluster/

2008-12-05 Thread Jim Jagielski
On Dec 5, 2008, at 4:21 AM, Paul Querna wrote: Is there any reason why we must use either APR_LOCK_FCNTL or APR_LOCK_FLOCK, wouldn't the default mutex work? The default lock mech on OSX is sysvsem. I couldn't get it to work properly after forking at all. Maybe I was doing something

Re: svn commit: r721952 - in /httpd/httpd/trunk: ./ modules/ modules/cluster/

2008-12-05 Thread Rainer Jung
Jim Jagielski schrieb: On Dec 5, 2008, at 4:21 AM, Paul Querna wrote: Is there any reason why we must use either APR_LOCK_FCNTL or APR_LOCK_FLOCK, wouldn't the default mutex work? The default lock mech on OSX is sysvsem. I couldn't get it to work properly after forking at all. Maybe

Re: svn commit: r721952 - in /httpd/httpd/trunk: ./ modules/ modules/cluster/

2008-12-01 Thread Ruediger Pluem
On 12/01/2008 03:55 AM, [EMAIL PROTECTED] wrote: Author: pquerna Date: Sun Nov 30 18:55:14 2008 New Revision: 721952 URL: http://svn.apache.org/viewvc?rev=721952view=rev Log: Add two new modules, originally written at Joost, to handle load balancing across multiple apache servers