回复: Re:How to write a performance test program

2019-12-23 Thread ma...@bonc.com.cn
Thank you, I have replaced it with hubi-spark-bundle-0.5.0-incubating.jar, and the program seems to be stable. ma...@bonc.com.cn 发件人: lamberken 发送时间: 2019-12-24 11:24 收件人: dev 主题: Re:How to write a performance test program Hi @mayu1, I guess you used the latest master branch, this bug

Re:Re: How to write a performance test program

2019-12-23 Thread lamberken
Hi @Vinoth, Here are reproduce steps. 1, Build from latest source mvn clean package -DskipTests -DskipITs -Dcheckstyle.skip=true -Drat.skip=true 2, Write Data export SPARK_HOME=/work/BigData/install/spark/spark-2.3.3-bin-hadoop2.6 ${SPARK_HOME}/bin/spark-shell --jars `ls

Re: How to write a performance test program

2019-12-23 Thread Vinoth Chandar
Could you give 0.5.0-incubating (last release) a shot in the meantime? Lamberken, do you have steps to reproduce this issue. Love to get a JIRA filed so we could fix before the next release. On Mon, Dec 23, 2019 at 7:25 PM lamberken wrote: > > Hi @mayu1, > > I guess you used the latest master

Fwd: Re: IDE setup for code formatting

2019-12-23 Thread Vinoth Chandar
Awesome. Thanks!! -- Forwarded message - From: lamberken Date: Mon, Dec 23, 2019 at 7:11 PM Subject: Re:Re: IDE setup for code formatting To: CC: Minh Pham Hi @Vinoth Okay, I will talk with @leesf about the checkstyle. At the end we will give a relatively better solution.

JIRA permission opening application

2019-12-23 Thread Jiaqi Li
Hi, I want to contribute to Apache Hudi. Would you please give me the contributor permission? My JIRA ID is sev7e0. Best sev7e0

Re:Re: IDE setup for code formatting

2019-12-23 Thread lamberken
Hi @Vinoth Okay, I will talk with @leesf about the checkstyle. At the end we will give a relatively better solution. best, lamber-ken At 2019-12-24 11:00:12, "Vinoth Chandar" wrote: >Ironically, google style + checkstyle is what we had few months ago :) > >Can we have an owner to drive

How to write a performance test program

2019-12-23 Thread ma...@bonc.com.cn
hello! I want to modify the quickstart program for performance testing and generate a dataset of ten million rows. However, the program will report an error after running it multiple times. error: Exception in thread "main" org.apache.hudi.exception.HoodieCommitException: Failed to archive

Re: IDE setup for code formatting

2019-12-23 Thread Vinoth Chandar
Ironically, google style + checkstyle is what we had few months ago :) Can we have an owner to drive this to a point where, the code formatting is well-documented for contributors? leesf. and lamber, seems like you have the most context? On Mon, Dec 23, 2019 at 6:24 PM lamber...@163.com wrote:

apply for contributor permission

2019-12-23 Thread yuehan...@163.com
Hello, I want to contribute to Apache Hudi. Would you please give me the contributor permission? Here is my accounts: apache jira username: yuehan124 apache github username: yuehan124 apache cwiki username: yuehan124 Thanks! yuehan...@163.com

Re: IDE setup for code formatting

2019-12-23 Thread lamberken

Re: IDE setup for code formatting

2019-12-23 Thread Minh Pham
Google Java Formatter is an automated tool so it can reformat the entire codebase in 1 shot. Sent from my iPhone > On Dec 23, 2019, at 4:55 PM, lamberken wrote: > >  > > Hi @Minh Pham > > > I agree what @Y Ethan Guo says, we can disable those checkstyle rules which > can not be automated

contributor permission

2019-12-23 Thread Leping Huang
Hi, I want to contribute to Apache Hudi. Would you please give me the contributor permission? My JIRA username is soundhearer.

Re: IDE setup for code formatting

2019-12-23 Thread lamberken
Hi @Minh Pham I agree what @Y Ethan Guo says, we can disable those checkstyle rules which can not be automated for reformatting for now. If we replace all new rules with google code style, it may takes more time to fix. best, lamber-ken On 12/24/2019 03:34,Minh Pham wrote: What do you guys

Re:Re: Re: IDE setup for code formatting

2019-12-23 Thread lamberken
Hi @Y Ethan Guo, I am very willing to follow the community's decision. And your idea is very good, we can disable those checkstyle rules that cannot be automated for reformatting in IDE for now. best, lamber-ken At 2019-12-24 03:38:55, "Y Ethan Guo" wrote: >+1 on auto-formatting the

Re: Re: IDE setup for code formatting

2019-12-23 Thread Y Ethan Guo
+1 on auto-formatting the code in IDE based on the checkstyle rules. Based on my experience with Java and Scala in IntelliJ, there's is indeed discrepancy on auto formatting code on some custom checkstyle rules. For such cases, I tried to avoid using them if they do not sacrifice too much on the

Re: IDE setup for code formatting

2019-12-23 Thread Minh Pham
What do you guys think about Google Java Formater? My opinion is that code style that can’t be automated is not worth enforcing.

Re: Re: IDE setup for code formatting

2019-12-23 Thread nishith agarwal
Vinoth, +1 on automating the manual work required at the moment to fix the checkstyle errors. I think if we are able to use spotless and at the same time know upfront all the things that would require manual work, there are few options IMO : a) Have a template of steps that can easily fix it ->

This week's sync meeting

2019-12-23 Thread Vinoth Chandar
Folks, I will not be able to attend this week's meeting. Please go ahead without me and send notes to the group as usual Cheers Vinoth

Re: Re: IDE setup for code formatting

2019-12-23 Thread Sivabalan
My 2 cents: I am also a big fan of code formatting in general, given that its fully automated. But if that comes at the cost of taking some time off everyone's time(manual fixing), we need to think through if its really worth it. Especially, wrt import order, I am not sure if that really adds

Re: Facing issues when using HiveIncrementalPuller

2019-12-23 Thread Vinoth Chandar
Hi Pratyaksh, HveIncrementalPuller is just a java program. Does not need Spark, since it just runs a HiveQL remotely.. On the error you specified, seems like it can't find the template? Can you see if the bundle does not have the template file.. May be this got broken during the bundling

Re: Re: IDE setup for code formatting

2019-12-23 Thread Vinoth Chandar
Can we exhaustively list all that will be manually even after spotless plugin is brought back? On Mon, Dec 23, 2019 at 3:01 AM leesf wrote: > After bringing spotless plugin back to project, it would automatically fix > comment check error except for import order error, we need to fix this >

Facing issues when using HiveIncrementalPuller

2019-12-23 Thread Pratyaksh Sharma
Hi, Can someone guide me or share some documentation regarding how to use HiveIncrementalPuller. I already went through the documentation on https://hudi.apache.org/querying_data.html. I tried using this puller using the below command and facing the given exception. Any leads are appreciated.

Re: Re: IDE setup for code formatting

2019-12-23 Thread leesf
After bringing spotless plugin back to project, it would automatically fix comment check error except for import order error, we need to fix this error manually. In Apache Flink/Calcite, we also fix it manually, and will also look for other plugins to fix import order error if exist. Best, Leesf

Re: Re: IDE setup for code formatting

2019-12-23 Thread Vinoth Chandar
I understand. I am saying - we should automate all of this formatting.. :) How do other projects do it? Other folks, who worked on the code refactoring/formatting, may be you can also chime in? On Mon, Dec 23, 2019 at 12:24 AM lamberken wrote: > Hi @Vinoth, > > > The ImportOrder is a custom

Re:Re: IDE setup for code formatting

2019-12-23 Thread lamberken
Hi @Vinoth, The ImportOrder is a custom rule, IDE may can not reformat codes rightly. We can highlight this rule on contributing guide. The new ImportOrder rule split import statements into groups and groups are separated by one blank line. These groups are 1) org.apache.hudi 2) third