Re: [DISCUSS] Support for `_hoodie_record_key` as a virtual column

2020-09-02 Thread Gary Li
Yes it works this way, IMO the performance of reading certain fields from the row and then to build the key from there is not as efficient as having a separate key from the actual record. But if we only make it virtual in the parquet then this should be fine. For parquet, the downside I could s

[DISCUSS] New Community Weekly Sync up Time

2020-09-02 Thread Pratyaksh Sharma
Hi everyone, Currently we are having weekly sync ups between 9 PM - 10 PM PST on tuesdays. Since I have switched my job last to last month (in India), this time is exactly clashing with the daily standup time at my current org. This is the reason I have not been able to attend the syncups for quit

Re: [DISCUSS] Support for `_hoodie_record_key` as a virtual column

2020-09-02 Thread Vinoth Chandar
Hi Gary, It should not be that bad, right. We can just create a new implementation of HoodieRecord where getKey() can dynamically fetch a field's value as the recordKey. Then the rest of the code should work as-is? On Tue, Sep 1, 2020 at 5:22 PM Gary Li wrote: > Thanks for the proposal. I am a

Re: Coding guidelines

2020-09-02 Thread Balaji Varadarajan
+1. All current and future contributors/committers need to read this. Balaji.V On Wednesday, September 2, 2020, 01:11:46 AM PDT, vino yang wrote: +1 to have the coding guidelines. Left some comments. Best, Vino Vinoth Chandar 于2020年9月2日周三 上午9:51写道: > Hello all, > > Put together a l

Re: Coding guidelines

2020-09-02 Thread vino yang
+1 to have the coding guidelines. Left some comments. Best, Vino Vinoth Chandar 于2020年9月2日周三 上午9:51写道: > Hello all, > > Put together a list to formalize the things we follow in code review > process today. Please chime in on the PR review, for comments. > > https://github.com/apache/hudi/pull/