Re: [DISCUSS] Introduce lgtm to analyze the changes of PR and simplify the cost of code review

2021-03-03 Thread vino yang
Hi, It did not provide much public information, but gave a description on the official website: *“Prevent bugs from ever making it to your project by using automated reviews that let you know when your code changes would introduce alerts into your project. We support GitHub and Bitbucket.We

Re: 0.8.0 Release discussion

2021-03-03 Thread Danny Chan
I'm happy to add the flink quick start part, use cases through the Flink CLI. Sivabalan 于2021年3月3日周三 下午11:52写道: > +1 for sure. Would be nice to add flink documentation to our QuickStart. We > need to probably fix docker demo as well, but alteast w/ upcoming release, > would be nice to have

Re: [DISCUSS] Introduce lgtm to analyze the changes of PR and simplify the cost of code review

2021-03-03 Thread nishith agarwal
This is a good idea @vino yang Have you looked into what the "automated code review" actually does ? -Nishith On Wed, Mar 3, 2021 at 7:38 AM vino yang wrote: > Hi guys, > > I want to introduce a code analysis service called lgtm[1] in the > community. Recently, in the Kylin community, I

Re: 0.8.0 Release discussion

2021-03-03 Thread Sivabalan
+1 for sure. Would be nice to add flink documentation to our QuickStart. We need to probably fix docker demo as well, but alteast w/ upcoming release, would be nice to have quick start added for flink. So, please do incorporate the time required for it (including fixing website ). May be take the

[DISCUSS] Introduce lgtm to analyze the changes of PR and simplify the cost of code review

2021-03-03 Thread vino yang
Hi guys, I want to introduce a code analysis service called lgtm[1] in the community. Recently, in the Kylin community, I found it in my colleague's PR.[2] lgtm is a code analysis platform for finding zero-days and preventing critical vulnerabilities. Some features listed here (copied from its

Re: [DISCUSS] Support multiple ordering fields

2021-03-03 Thread Danny Chan
It is reasonable to support multiple ordering fields. The ordering fields semantics is very similar with the SQL PRIMARY KEY, the PRIMARY KEY did support multiple fields. A little different with PRIMARY KEY is that, current ordering field also supports nested fields, E.G. "a.b.c", which the