Re: Committership guidelines

2019-08-07 Thread Vinoth Chandar
Got a few reviews on the PR. So going ahead and merging. Please feel free to still leave comments on the PR, if you still have em. On Mon, Aug 5, 2019 at 9:10 AM Vinoth Chandar wrote: > Gentle reminder to review this PR! :) Have a great week! > > On Fri, Aug 2, 2019 at 5:29 AM Vinoth Chandar

Re: Committership guidelines

2019-08-05 Thread Vinoth Chandar
Gentle reminder to review this PR! :) Have a great week! On Fri, Aug 2, 2019 at 5:29 AM Vinoth Chandar wrote: > hello all, > > Put up a draft here https://github.com/apache/incubator-hudi/pull/823 > Please review > > /thanks/vinoth > > On Tue, Jul 30, 2019 at 9:53 PM vino yang wrote: > >> +1

Re: Committership guidelines

2019-08-02 Thread Vinoth Chandar
hello all, Put up a draft here https://github.com/apache/incubator-hudi/pull/823 Please review /thanks/vinoth On Tue, Jul 30, 2019 at 9:53 PM vino yang wrote: > +1 > > IMO, the guidelines of both Flink and Beam are good. We can learn all the > advantages of them. > > Best, > Vino > > Thomas

Re: Committership guidelines

2019-07-30 Thread vino yang
+1 IMO, the guidelines of both Flink and Beam are good. We can learn all the advantages of them. Best, Vino Thomas Weise 于2019年7月31日周三 上午4:52写道: > Hi Vinoth, > > Take a look at this as well: > https://beam.apache.org/contribute/become-a-committer/ > > It is not just the criteria, but more so

Re: Committership guidelines

2019-07-30 Thread Thomas Weise
Hi Vinoth, Take a look at this as well: https://beam.apache.org/contribute/become-a-committer/ It is not just the criteria, but more so the path to get there. And what we can do to encourage and recognize contributions. Thomas On Tue, Jul 30, 2019 at 11:30 AM Suneel Marthi wrote: > Please

Re: Committership guidelines

2019-07-30 Thread Suneel Marthi
Please go ahead - we can review the PR. On Tue, Jul 30, 2019 at 1:51 PM Vinoth Chandar wrote: > +1 looks good. > > If no one objects (lazy consensus), I will draft a PR based on this (and > may be 1 more project) and share here? > > On Mon, Jul 29, 2019 at 10:56 AM Suneel Marthi wrote: > > >

Re: Committership guidelines

2019-07-30 Thread Vinoth Chandar
+1 looks good. If no one objects (lazy consensus), I will draft a PR based on this (and may be 1 more project) and share here? On Mon, Jul 29, 2019 at 10:56 AM Suneel Marthi wrote: > A good start here ---> > https://flink.apache.org/contributing/how-to-contribute.html > > On Mon, Jul 29, 2019

Re: Committership guidelines

2019-07-29 Thread Suneel Marthi
A good start here ---> https://flink.apache.org/contributing/how-to-contribute.html On Mon, Jul 29, 2019 at 1:54 PM Vinoth Chandar wrote: > Hello mentors, > > I realized that we have not replaced our committership criteria with new > ones, post the move to ASF. Would like to get that ball

Committership guidelines

2019-07-29 Thread Vinoth Chandar
Hello mentors, I realized that we have not replaced our committership criteria with new ones, post the move to ASF. Would like to get that ball rolling. This seems like something we vote on? what do you think? /thanks/vinoth