Re: iBATIS 3 XML SQL Map Decisions...

2008-08-16 Thread Jeff Butler
+1 definitely - no more question marks. Jeff Butler On Sat, Aug 16, 2008 at 12:34 AM, Clinton Begin <[EMAIL PROTECTED]>wrote: > One thing I forgot to mention... > > With iB3 I don't think we should support question mark parameters at all > anymore. So even if you specify the elements, they're

Re: iBATIS 3 XML SQL Map Decisions...

2008-08-16 Thread Jeff Butler
Excellent! Now I can change ibator so that it can be used to generate queries that return 50 billion rows and suck up all your network bandwidth! (Just kidding) Jeff Butler On Fri, Aug 15, 2008 at 10:46 PM, Clinton Begin <[EMAIL PROTECTED]>wrote: > The coolest thing... this test passes in iBATI

Re: iBATIS 3 XML SQL Map Decisions...

2008-08-16 Thread Kai Grabfelder
besides the discussion about the structure of the xml I have one wish: Could you describe the xml with an xml schema instead of a dtd? It's just more accurate to describe complex xmls with a schema instead of dtd. Regards Kai --- Original Nachricht --- Absender: Clinton Begin Datum: 13.08.200

Re: iBATIS 3 XML SQL Map Decisions...

2008-08-16 Thread Kai Grabfelder
+1 for changing the silentlyFailWhenNoResultClassOrResultMapPresent behaviour, I have to admit I stumpled across this problem for several times ;-) --- Original Nachricht --- Absender: Larry Meadors Datum: 16.08.2008 07:42 Amen! ? = ambiguous One more thing: What about a shootFlamesOutTheBack

Re: iBATIS 3 XML SQL Map Decisions...

2008-08-15 Thread Larry Meadors
Amen! ? = ambiguous One more thing: What about a shootFlamesOutTheBackOfTheComputerWhenNoResultClassOrResultMapPresent setting somewhere to offset the silentlyFailWhenNoResultClassOrResultMapPresent default. ;-) Maybe even have a default result mapping option - if all else fails, just dump the r

Re: iBATIS 3 XML SQL Map Decisions...

2008-08-15 Thread Clinton Begin
One thing I forgot to mention... With iB3 I don't think we should support question mark parameters at all anymore. So even if you specify the elements, they're no longer ordinal. They are looked up from the #param placeholders in the statement. That way SQL is more readable, and even the eleme

Re: iBATIS 3 XML SQL Map Decisions...

2008-08-15 Thread Larry Meadors
On Wed, Aug 13, 2008 at 4:27 PM, Clinton Begin <[EMAIL PROTECTED]> wrote: > 3. : The thought here is to allow for specifying the > options (e.g. javaType="") outside of the SQL statement and to avoid > duplication if the same property is used more than once. But maybe it's too > much for such a

Re: iBATIS 3 XML SQL Map Decisions...

2008-08-15 Thread Clinton Begin
The coolest thing... this test passes in iBATIS 3... no changes, it just worked. Clinton On Thu, Aug 14, 2008 at 12:44 PM, Jeff Butler <[EMAIL PROTECTED]> wrote: > That's the general idea. I'm not sure of the merits of it or not. The pro > is that you could fill out a graph with one query. Th

Re: iBATIS 3 XML SQL Map Decisions...

2008-08-13 Thread Clinton Begin
Couple of notes... * The top level call was for a list of categories (not just one). * I adapted this test from an existing test where categories had many products, which in turn had many items. So that would seem to be almost all of the possible cases... combinations of those should work, b

Re: iBATIS 3 XML SQL Map Decisions...

2008-08-13 Thread Clinton Begin
I just wrote a little unit test for that. It totally works. Here's the ResultMap to make sure we're talking about the same thing * * Clinton On Wed, Aug 13, 2008 at 10:17 PM, Larry Meador

Re: iBATIS 3 XML SQL Map Decisions...

2008-08-13 Thread Larry Meadors
On Wed, Aug 13, 2008 at 4:27 PM, Clinton Begin <[EMAIL PROTECTED]> wrote: > 4. groupBy is gone completely. The element combined with the > ID element now work together to achieve this. I agree the old > implementation was annoying. What do you mean by multiple independent > lists? Does that n

Re: iBATIS 3 XML SQL Map Decisions...

2008-08-13 Thread Clinton Begin
3. : The thought here is to allow for specifying the options (e.g. javaType="") outside of the SQL statement and to avoid duplication if the same property is used more than once. But maybe it's too much for such a rare case? But still, some people may prefer to keep the param details out of the

Re: iBATIS 3 XML SQL Map Decisions...

2008-08-13 Thread Jeff Butler
Some comments: 1. Looks good! 2. Enclosing elements seems OK to me 3. +1 on killing parameter maps. I strongly dislike declared parameter maps and think that they are constantly misused/misunderstood. I'm not clear what the benefit of the element is - why not force inline parameters 100% of the

Re: iBATIS 3 XML SQL Map Decisions...

2008-08-13 Thread Clinton Begin
BTW: It's probably best to copy and paste that XML into an editor, it doesn't read very well in an email window On Tue, Aug 12, 2008 at 11:50 PM, Clinton Begin <[EMAIL PROTECTED]>wrote: > Hey all, > > I'd like to get some feedback on the things you like and dislike about the > current XML, a

Re: iBATIS 3 XML SQL Map Decisions...

2008-08-13 Thread Brandon Goodin
The only thing that i would note would be that the dynamic sql should also contain an or a . B On Wed, Aug 13, 2008 at 12:50 AM, Clinton Begin <[EMAIL PROTECTED]> wrote: > Hey all, > > I'd like to get some feedback on the things you like and dislike about the > current XML, and also show you so