Re: iBATIS 3 XML SQL Map Decisions...

2008-08-16 Thread Kai Grabfelder
besides the discussion about the structure of the xml I have one wish: Could you describe the xml with an xml schema instead of a dtd? It's just more accurate to describe complex xmls with a schema instead of dtd. Regards Kai --- Original Nachricht --- Absender: Clinton Begin Datum:

Re: iBATIS 3 XML SQL Map Decisions...

2008-08-16 Thread Jeff Butler
Excellent! Now I can change ibator so that it can be used to generate queries that return 50 billion rows and suck up all your network bandwidth! (Just kidding) Jeff Butler On Fri, Aug 15, 2008 at 10:46 PM, Clinton Begin [EMAIL PROTECTED]wrote: The coolest thing... this test passes in iBATIS

Re: iBATIS 3 XML SQL Map Decisions...

2008-08-16 Thread Jeff Butler
+1 definitely - no more question marks. Jeff Butler On Sat, Aug 16, 2008 at 12:34 AM, Clinton Begin [EMAIL PROTECTED]wrote: One thing I forgot to mention... With iB3 I don't think we should support question mark parameters at all anymore. So even if you specify the param elements, they're

Re: iBATIS 3 XML SQL Map Decisions...

2008-08-15 Thread Larry Meadors
On Wed, Aug 13, 2008 at 4:27 PM, Clinton Begin [EMAIL PROTECTED] wrote: 3. param element : The thought here is to allow for specifying the options (e.g. javaType=) outside of the SQL statement and to avoid duplication if the same property is used more than once. But maybe it's too much for

Re: iBATIS 3 XML SQL Map Decisions...

2008-08-15 Thread Clinton Begin
One thing I forgot to mention... With iB3 I don't think we should support question mark parameters at all anymore. So even if you specify the param elements, they're no longer ordinal. They are looked up from the #param placeholders in the statement. That way SQL is more readable, and even the

Re: iBATIS 3 XML SQL Map Decisions...

2008-08-13 Thread Brandon Goodin
The only thing that i would note would be that the dynamic sql should also contain an choose/when/otherwise or a choose/if/else. B On Wed, Aug 13, 2008 at 12:50 AM, Clinton Begin [EMAIL PROTECTED] wrote: Hey all, I'd like to get some feedback on the things you like and dislike about the

Re: iBATIS 3 XML SQL Map Decisions...

2008-08-13 Thread Jeff Butler
Some comments: 1. Looks good! 2. Enclosing elements seems OK to me 3. +1 on killing parameter maps. I strongly dislike declared parameter maps and think that they are constantly misused/misunderstood. I'm not clear what the benefit of the param element is - why not force inline parameters 100%

Re: iBATIS 3 XML SQL Map Decisions...

2008-08-13 Thread Larry Meadors
On Wed, Aug 13, 2008 at 4:27 PM, Clinton Begin [EMAIL PROTECTED] wrote: 4. groupBy is gone completely. The collection element combined with the ID element now work together to achieve this. I agree the old implementation was annoying. What do you mean by multiple independent lists? Does

Re: iBATIS 3 XML SQL Map Decisions...

2008-08-13 Thread Clinton Begin
I just wrote a little unit test for that. It totally works. Here's the ResultMap to make sure we're talking about the same thing resultMap id=categoryResultMap class=testdomain.Category groupBy=categoryId result property=categoryId column=catid/ result property=name column=catname/

iBATIS 3 XML SQL Map Decisions...

2008-08-12 Thread Clinton Begin
Hey all, I'd like to get some feedback on the things you like and dislike about the current XML, and also show you some of the new XML. Without too much talk... here's what I've started out with for the new iBATIS 3 mappings Note that while this XML may look similarly verbose, realize that a