Re: Flaky tests

2020-10-16 Thread Peter Vary
Thanks Junjie for checking! I was not able to repro the case you shown below, but I was able to repro the original case on my laptop for a while. I found the RC and created a fix for it, but after a night sleep I am not able to repro again even without any changes. The pull request is here: htt

Re: Flaky tests

2020-10-16 Thread 俊杰陈
We met the issue several times when two CI builds run parallel. So I guess it could be reproduced when running two test builds in parallel. On Fri, Oct 16, 2020 at 5:16 PM Peter Vary wrote: > > Thanks Junjie for checking! > > I was not able to repro the case you shown below, but I was able to re

Incremental reads for Upsert!

2020-10-16 Thread Ashish Mehta
Hi, Is there a spec/proposal/milestone issue that talks about Incremental reads for UPSERT? i.e. allowing clients to read a dataSet's APPEND/DELETES with some options of exposing actually deleted rows. I am in view that exposing deleted rows might be trivial with positional deletes, so an option

Seeking Suggestions on Implementing NaN Counters for Metrics

2020-10-16 Thread Yan Yan
Hi Iceberg community, I'm from Amazon and very new to the space, so please bear with me for any naive questions. I'm currently looking into adding NaN counts for float and double columns (described in #348 ). I noticed that metrics like upper/lower boun