Re: Filtering on int96 timestamps

2021-05-06 Thread Scott Kruger
Nevermind about the intellij style; found it in .baseline/idea From: Ryan Blue Reply-To: "dev@iceberg.apache.org" Date: Thursday, May 6, 2021 at 12:34 PM To: "dev@iceberg.apache.org" Subject: Re: Filtering on int96 timestamps This message contains hyperlinks, take precaution before opening the

Re: Filtering on int96 timestamps

2021-05-06 Thread Scott Kruger
Somewhat related: do we have style settings that can be imported into intellij? Don’t want to rock the boat more than necessary. From: Ryan Blue Reply-To: "dev@iceberg.apache.org" Date: Thursday, May 6, 2021 at 12:34 PM To: "dev@iceberg.apache.org" Subject: Re: Filtering on int96 timestamps T

Re: Filtering on int96 timestamps

2021-05-06 Thread Scott Kruger
No worries. I’ll take a look and see if I can’t get a passing test. Thanks! From: Ryan Blue Reply-To: "dev@iceberg.apache.org" Date: Thursday, May 6, 2021 at 12:34 PM To: "dev@iceberg.apache.org" Subject: Re: Filtering on int96 timestamps This message contains hyperlinks, take precaution befor

Re: Filtering on int96 timestamps

2021-05-06 Thread Ryan Blue
Sorry, my bad for not checking out the github issue! Looks like we need to update `ParquetMetricsRowGroupFilter` to ignore INT96 stats. I think we can probably do that when getting the stats from file metadata, here: https://github.com/apache/iceberg/blob/master/parquet/src/main/java/org/apache/ice

Re: Filtering on int96 timestamps

2021-05-06 Thread Scott Kruger
The github issue has a strack trace (as well as a diff to a unit test that illiustrates the problem). I can add some more context if needed. The gist is that a ClassCastException is thrown because, during the filter step when it’s comparing the value against the upper/lower bounds, it wants to

Re: Filtering on int96 timestamps

2021-05-06 Thread Ryan Blue
Scott, can you tell me more about where this is failing? I think we should definitely update Iceberg to ignore INT96 columns when filtering. I'm surprised that it isn't already happening since we don't have metadata for those columns. Sounds like it may be somewhere in our Parquet row group or dic

Re: Cannot build iceberg locally

2021-05-06 Thread Taher Koitawala
Similiar issue as the ticket link. I will try that. Thanks guys On Thu, May 6, 2021, 9:30 PM Jack Ye wrote: > Sounds like something similar to > https://github.com/apache/iceberg/issues/1750. > We might want to add an IDE setup section in the website for this. > -Jack > > On Thu, May 6, 2021 at

Re: Cannot build iceberg locally

2021-05-06 Thread Jack Ye
Sounds like something similar to https://github.com/apache/iceberg/issues/1750. We might want to add an IDE setup section in the website for this. -Jack On Thu, May 6, 2021 at 8:58 AM Daniel Weeks wrote: > Hey Taher, > > Based on your description of "cannot resolve", it sounds to me like your >

Re: Cannot build iceberg locally

2021-05-06 Thread Daniel Weeks
Hey Taher, Based on your description of "cannot resolve", it sounds to me like your IDE (probably IntelliJ?) isn't seeing the bundled guava packages and shows them as broken/unresolvable. I assume the build actually succeeded. This can be somewhat finicky from my experience, but typically if you

Re: Filtering on int96 timestamps

2021-05-06 Thread Scott Kruger
Is there any way to prevent the pushdown for int96 columns? At least that would prevent spark from crashing. (Aside: this is kind of a bummer, as I was able to get the unit test passing last night; I guess it wouldn’t work for all cases though). From: Ryan Blue Reply-To: "dev@iceberg.apache.or

Re: Cannot build iceberg locally

2021-05-06 Thread Mass Dosage
Hello Taher, Can you share a bit more of the error message you're seeing? Perhaps attach a longer portion of the log showing all the gradle(?) output? Where exactly is the problem occurring that you can't resolve classes in the relocated package? Thanks, Adrian On Thu, 6 May 2021 at 13:28, Tahe

Cannot build iceberg locally

2021-05-06 Thread Taher Koitawala
Hi All, Very silly help needed. I am trying to work on the metadata file version test cases and I want to build iceberg locally. I cloned the master branch and ran - ./gradlew build -x test on the root directory. everything builds however I am still not able to resolve org.apache.ic