Re: [VOTE] Release Apache Iceberg 0.12.1 RC0

2021-11-05 Thread OpenInx
+1 (binding) 1. Download the source tarball, signature (.asc), and checksum (.sha512): OK 2. Import gpg keys: download KEYS and run gpg --import /path/to/downloaded/KEYS (optional if this hasn’t changed) : OK 3. Verify the signature by running: gpg --verify apache-iceberg-xx-incubating.tar.gz.a

Re: Standard practices around PRs against multiple Spark versions

2021-11-05 Thread Yufei Gu
It is a good practice to create a template for Github Issues and PRs . It will make a PR or issue easier to read overall. We can also enforce/sug

Re: Standard practices around PRs against multiple Spark versions

2021-11-05 Thread Kyle Bendickson
I like Yufei's idea of adding a template. As per the concern about making changes separate and having things fall through the cracks, I do share that concern. On a related note though, I've already observed that a few times with simple things that maybe people were working on before the split up.

Re: Standard practices around PRs against multiple Spark versions

2021-11-05 Thread Ryan Blue
I agree with Jack about keeping changes targeted at one Spark version. That makes it possible to revert changes to one Spark version rather than manually rolling back. And it also keeps PRs smaller and more focused. I think it wastes more contributor time to make updates to a PR in 3 or 4 places an

Re: Standard practices around PRs against multiple Spark versions

2021-11-05 Thread Jack Ye
definitely +1 for having documentations to point to instead of laying everything out in the PR template! -Jack On Fri, Nov 5, 2021 at 2:55 PM Ryan Blue wrote: > I agree with Jack about keeping changes targeted at one Spark version. > That makes it possible to revert changes to one Spark version

Re: [VOTE] Release Apache Iceberg 0.12.1 RC0

2021-11-05 Thread Sam Redai
+1 (non-binding) signature, checksum, license, build and test On Fri, Nov 5, 2021 at 12:36 AM OpenInx wrote: > +1 (binding) > > 1. Download the source tarball, signature (.asc), and checksum (.sha512): > OK > 2. Import gpg keys: download KEYS and run gpg --import > /path/to/downloaded/KEYS (op