That makes sense. I've updated the PR: https://github.com/apache/iceberg-python/pull/410/ PTAL.
Kind regards, Fokko Op zo 11 feb 2024 om 03:58 schreef Justin Mclean <jus...@classsoftware.com>: > HI, > > For the Thrift and Hive ones, we have an optional dependency that ships > the content under the vendor/ directory: > https://github.com/apache/iceberg-python/tree/main/vendor These are the > Python Thrift code for talking Thrift to the Hive metastore. Both the Hive > and Thrift NOTICES are empty, we can add the "This product includes > software developed at the Apache Software Foundation...", but that seems > to be optional > <https://infra.apache.org/licensing-howto.html#bundle-asf-product>. > > > Yes, there is no need to repeat, "This product includes software developed > at The Apache Software Foundation (http://www.apache.org/).” It only > needs to be included once. > > Kind Regards, > Justin >