Re: [DISCUSS] Forward compatibility and snapshot ID inheritance

2020-01-14 Thread Romin Parekh
43 PM > *To:* "Iceberg Dev List"; > *Cc:* "Ryan Blue"; > *Subject:* Re: [DISCUSS] Forward compatibility and snapshot ID inheritance > > +1 on feature flag in this case. > > I encourage everyone interested to take a look at the PR itself [1]. There > are a f

Re: [DISCUSS] Forward compatibility and snapshot ID inheritance

2020-01-14 Thread chenjunjiedada

Re: [DISCUSS] Forward compatibility and snapshot ID inheritance

2020-01-14 Thread Anton Okolnychyi
+1 on feature flag in this case. I encourage everyone interested to take a look at the PR itself [1]. There are a few open things to address, though. - Anton [1] - https://github.com/apache/incubator-iceberg/pull/675 > On 14 Jan 2020, at

Re: [DISCUSS] Forward compatibility and snapshot ID inheritance

2020-01-13 Thread Gautam
A feature flag sounds good to me with associated regression tests to pair along with each feature. Re: Snapshot Id Inheritance, would be good to update the spec with the change in metadata guarantees. -Gautam. On Mon, Jan 13, 2020 at 11:28 AM Ryan Blue wrote: > Hi everyone, > > Anton has a PR

Re: [DISCUSS] Forward compatibility and snapshot ID inheritance

2020-01-13 Thread Xabriel Collazo Mojica
Blue Reply-To: "dev@iceberg.apache.org" , "rb...@netflix.com" Date: Monday, January 13, 2020 at 11:28 AM To: Iceberg Dev List Subject: [DISCUSS] Forward compatibility and snapshot ID inheritance Hi everyone, Anton has a PR almost ready to merge that implements snapshot ID i

[DISCUSS] Forward compatibility and snapshot ID inheritance

2020-01-13 Thread Ryan Blue
Hi everyone, Anton has a PR almost ready to merge that implements snapshot ID inheritance, similar to how we plan to inherit sequence IDs in metadata. That allows people to create manifests that are missing data that will be assigned at commit time (snapshot ID) or that may change if a commit is r