Re: [Discuss] Geospatial Support

2024-09-30 Thread rdb...@gmail.com
I have a couple of comments that I'd like to see addressed. First, I think that the definition of the bounding box needs to be more clear: the bounding box must include all points that lie on an object's edges or within an object. If that isn't required then we can't use the bounding box for filte

Re: [Discuss] Geospatial Support

2024-09-30 Thread Yufei Gu
Thanks Szehon! My comments were addressed. I'm ready to vote. Yufei On Mon, Sep 30, 2024 at 11:47 AM Russell Spitzer wrote: > All my concerns are addressed, I'm ready to vote. > > On Mon, Sep 30, 2024 at 1:21 PM Szehon Ho wrote: > >> Hi all, >> >> There have been several rounds of discussion

Re: [Discuss] Geospatial Support

2024-09-30 Thread Russell Spitzer
All my concerns are addressed, I'm ready to vote. On Mon, Sep 30, 2024 at 1:21 PM Szehon Ho wrote: > Hi all, > > There have been several rounds of discussion on the PR: > https://github.com/apache/iceberg/pull/10981 and I think most of the main > points have been addressed. > > If anyone is inte

Re: [Discuss] Geospatial Support

2024-09-30 Thread Szehon Ho
Hi all, There have been several rounds of discussion on the PR: https://github.com/apache/iceberg/pull/10981 and I think most of the main points have been addressed. If anyone is interested, please take a look. If there are no other major points, we plan to start a VOTE thread soon. I know Jia

Re: [Discuss] Geospatial Support

2024-08-20 Thread Szehon Ho
Hi all Please take a look at the proposed spec change to support Geo type for V3 in : https://github.com/apache/iceberg/pull/10981, and comment or otherwise let me know your thoughts. Just as an FYI it incorporated the feedback from our last meeting (with Snowflake and Wherobots engineers). Than

Re: [Discuss] Geospatial Support

2024-06-26 Thread Szehon Ho
Hi It was great to meet in person with Snowflake engineers and we had a good discussion on the paths forward. Meeting notes for Snowflake- Iceberg sync. - Iceberg proposed Geometry type defaults to (edges=planar , crs=CRS84). - Snowflake has two types Geography (spherical) and Geometry (pl

Re: [Discuss] Geospatial Support

2024-06-18 Thread Szehon Ho
Jia and I will sync with the Snowflake folks to see if we can have a solution, or roadmap to solution, in the proposal. Thanks JB for the interest! By the way, I want to schedule a meeting to go over the proposal, it seems there's good feedback from folks from geo side (and even Parquet community

Re: [Discuss] Geospatial Support

2024-06-18 Thread Jean-Baptiste Onofré
Hi Jia Thanks for the update. I'm gonna re-read the whole thread and document to have a better understanding. Thanks ! Regards JB On Mon, Jun 17, 2024 at 7:44 PM Jia Yu wrote: > Hi Snowflake folks, > > Please let me know if you have other questions regarding the proposal. If > any, Szehon and

Re: [Discuss] Geospatial Support

2024-06-17 Thread Jia Yu
Hi Snowflake folks, Please let me know if you have other questions regarding the proposal. If any, Szehon and I can set up a zoom call with you guys to clarify some details. We are in the Pacific time zone. If you are in Europe, maybe early morning Pacific Time works best for you? Thanks, Jia On

Re: [Discuss] Geospatial Support

2024-06-05 Thread Gang Wu
> The min/max stats are discussed in the doc (Phase 2), depending on the non-trivial encoding. Just want to add that min/max stats filtering could be supported by file format natively. Adding geometry type to parquet spec is under discussion: https://github.com/apache/parquet-format/pull/240 Best

Re: [Discuss] Geospatial Support

2024-06-05 Thread Szehon Ho
Hi Peter Yes the document only concerns the predicate pushdown of geometric column. Predicate pushdown takes two forms, 1) partition filter and 2) min/max stats. The min/max stats are discussed in the doc (Phase 2), depending on the non-trivial encoding. The evaluators are always AND'ed together

Re: [Discuss] Geospatial Support

2024-06-05 Thread Peter Popov
Hi Szehon, hi Jia, Thank you for your replies. We now better understand the connection between the metadata and partitioning in this proposal. Supporting the Mapping 1 is a great starting point, and we would like to work closer with you on bringing the support for spherical edges and other coordin

Re: [Discuss] Geospatial Support

2024-05-29 Thread Jia Yu
Hi Dmtro, Thanks for your email. To add to Szehon's answer, 1. How to represent Snowflake Geometry and Geography type in Iceberg, given the Geo Iceberg Phase 1 design: Answer: Mapping 1 (possible): Snowflake Geometry + SRID: 4326 -> Iceberg Geometry + CRS84 + edges: Planar Mapping 2 (impossible)

Re: [Discuss] Geospatial Support

2024-05-29 Thread Szehon Ho
Hi Dmytro Thank you for looking through the proposal and excited to hear from you guys! I am not a 'geo expert' and I will definitely need to pull in Jia Yu for some of these points. Although most calculations are done on the query engine, Iceberg reference implementations (ie, Java, Python) doe

RE: [Discuss] Geospatial Support

2024-05-29 Thread Dmytro Koval
Dear Szehon and Iceberg Community, This is Dmytro, Peter, Aihua, and Tyler from Snowflake. As part of our desire to be more active in the Iceberg community, we’ve been looking over this geospatial proposal. We’re excited geospatial is getting traction, as we see a lot of geo usage within Snowflak

[Discuss] Geospatial Support

2024-05-01 Thread Szehon Ho
Hi everyone, We have created a formal proposal for adding Geospatial support to Iceberg. Please read the following for details. - Github Proposal : https://github.com/apache/iceberg/issues/10260 - Proposal Doc: https://docs.google.com/document/d/1iVFbrRNEzZl8tDcZC81GFt01QJkLJsI9E2NBOt2