[GitHub] [iceberg] rdblue commented on a diff in pull request #4444: Static Analysis: Use Instant instead of Date for string conversions

[GitBox]

rdblue commented on code in PR #4444:
URL: https://github.com/apache/iceberg/pull/4444#discussion_r841280570


##########
core/src/main/java/org/apache/iceberg/RemoveSnapshots.java:
##########
@@ -118,7 +118,7 @@ public ExpireSnapshots expireSnapshotId(long 
expireSnapshotId) {
 
   @Override
   public ExpireSnapshots expireOlderThan(long timestampMillis) {
-    LOG.info("Expiring snapshots older than: {} ({})", new 
Date(timestampMillis), timestampMillis);
+    LOG.info("Expiring snapshots older than: {} ({})", 
Instant.ofEpochMilli(timestampMillis), timestampMillis);

Review Comment:
   How about using `DateTimeUtil.formatTimestampMillis` instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org